aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Brown <mcb30@ipxe.org>2024-03-04 12:08:01 +0000
committerMichael Brown <mcb30@ipxe.org>2024-03-04 12:15:20 +0000
commit1b23d4de25d1dacf164eec442780bbfb026fbda7 (patch)
tree00a2ec8e75460811802c129cf4a74f49e9509206
parent7cd73884e51f6d3649aa2ea0ed0cec0b39192f61 (diff)
downloadipxe-1b23d4de25d1dacf164eec442780bbfb026fbda7.zip
ipxe-1b23d4de25d1dacf164eec442780bbfb026fbda7.tar.gz
ipxe-1b23d4de25d1dacf164eec442780bbfb026fbda7.tar.bz2
[efi] Use long forms of device paths in debug messages
We currently call ConvertDevicePathToText() with DisplayOnly=TRUE when constructing a device path to appear within a debug message. For ATAPI device paths, this will unfortunately omit some key information: the textual representation will not indicate which ATA bus or drive is represented. This can lead to misleading debug messages that appear to refer to identical devices. Fix by setting DisplayOnly=FALSE to select the long form of device path textual representations. Signed-off-by: Michael Brown <mcb30@ipxe.org>
-rw-r--r--src/interface/efi/efi_debug.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/interface/efi/efi_debug.c b/src/interface/efi/efi_debug.c
index ad79f0d..52efebe 100644
--- a/src/interface/efi/efi_debug.c
+++ b/src/interface/efi/efi_debug.c
@@ -479,7 +479,7 @@ efi_devpath_text ( EFI_DEVICE_PATH_PROTOCOL *path ) {
}
/* Convert path to a textual representation */
- wtext = efidpt->ConvertDevicePathToText ( path, TRUE, FALSE );
+ wtext = efidpt->ConvertDevicePathToText ( path, FALSE, FALSE );
if ( ! wtext )
return NULL;