From 40d8ad25e2160583c6d74a10e7599253d3b292ce Mon Sep 17 00:00:00 2001 From: Greg Hudson Date: Fri, 2 Aug 2013 11:37:40 -0400 Subject: Fix leak in krb5_krcc_unparse_cred on error Based on a patch from simo@redhat.com. --- src/lib/krb5/ccache/cc_keyring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/lib') diff --git a/src/lib/krb5/ccache/cc_keyring.c b/src/lib/krb5/ccache/cc_keyring.c index 3828c59..55c7711 100644 --- a/src/lib/krb5/ccache/cc_keyring.c +++ b/src/lib/krb5/ccache/cc_keyring.c @@ -1913,7 +1913,7 @@ krb5_krcc_unparse_cred(krb5_context context, krb5_ccache id, krb5_creds * creds, char **datapp, unsigned int *lenptr) { krb5_error_code kret; - char *buf; + char *buf = NULL; krb5_krcc_bc bc; if (!creds || !datapp || !lenptr) @@ -1963,9 +1963,11 @@ krb5_krcc_unparse_cred(krb5_context context, krb5_ccache id, /* Success! */ *datapp = buf; *lenptr = bc.bpp - buf; + buf = NULL; kret = KRB5_OK; errout: + free(buf); return kret; } -- cgit v1.1