diff options
| author | Tom Yu <tlyu@mit.edu> | 2007-04-25 21:49:14 +0000 |
|---|---|---|
| committer | Tom Yu <tlyu@mit.edu> | 2007-04-25 21:49:14 +0000 |
| commit | ad50f571d9de4490667f633c6c1b5fc3f1a89b25 (patch) | |
| tree | 2ebd4c93cf8e70c2d2e94482b4d9aec7984582fc /src | |
| parent | 6354d58805cfa646ecbb3bca6704b757343bf5b7 (diff) | |
| download | krb5-ad50f571d9de4490667f633c6c1b5fc3f1a89b25.zip krb5-ad50f571d9de4490667f633c6c1b5fc3f1a89b25.tar.gz krb5-ad50f571d9de4490667f633c6c1b5fc3f1a89b25.tar.bz2 | |
pull up r19526 from trunk
r19526@cathode-dark-space: tlyu | 2007-04-25 17:19:07 -0400
ticket: new
target_version: 1.6.2
tags: pullup
subject: race condition in referrals fallback
* src/lib/krb5/krb/gc_frm_kdc.c (krb5_get_cred_from_kdc_opt):
During referrals fallback, set *tgts to NULL after freeing. This
avoids returning a pointer to freed memory when the first call to
do_traversal() obtains some TGTs and the subsequent
krb5_cc_retrieve_cred() of the final-hop TGT succeeds (due to some
other thread or process storing that TGT into the ccache), causing
second do_traversal() call (which would re-initialize *tgts) to
not execute. Race condition found during KfW-3.2 testing.
ticket: 5546
version_fixed: 1.6.2
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19528 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src')
| -rw-r--r-- | src/lib/krb5/krb/gc_frm_kdc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/lib/krb5/krb/gc_frm_kdc.c b/src/lib/krb5/krb/gc_frm_kdc.c index 4890bad..5b9d391 100644 --- a/src/lib/krb5/krb/gc_frm_kdc.c +++ b/src/lib/krb5/krb/gc_frm_kdc.c @@ -1043,6 +1043,7 @@ krb5_get_cred_from_kdc_opt(krb5_context context, krb5_ccache ccache, krb5_free_creds(context, (*tgts)[i]); } free(*tgts); + *tgts = NULL; } context->use_conf_ktypes = 1; retval = krb5_cc_retrieve_cred(context, ccache, RETR_FLAGS, |