diff options
| author | Tom Yu <tlyu@mit.edu> | 2005-09-22 16:46:50 +0000 |
|---|---|---|
| committer | Tom Yu <tlyu@mit.edu> | 2005-09-22 16:46:50 +0000 |
| commit | 9199e04b96a9632b8ecea31f6b6e8fa48da1de32 (patch) | |
| tree | 81999a4d1dee1f1a708c2ff39ddccf2470d7af8f /src/lib | |
| parent | c02a7929608e666491eb85646a5631e2b98a5ec4 (diff) | |
| download | krb5-9199e04b96a9632b8ecea31f6b6e8fa48da1de32.zip krb5-9199e04b96a9632b8ecea31f6b6e8fa48da1de32.tar.gz krb5-9199e04b96a9632b8ecea31f6b6e8fa48da1de32.tar.bz2 | |
gss_release_buffer can leak zero-length buffers
* rel_buffer.c (generic_gss_release_buffer): Free buffer even if
length is zero. This avoids memory leaks in some cases.
ticket: new
target_version: 1.4.3
tags: pullup
component: krb5-libs
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17388 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/gssapi/generic/ChangeLog | 5 | ||||
| -rw-r--r-- | src/lib/gssapi/generic/rel_buffer.c | 3 |
2 files changed, 6 insertions, 2 deletions
diff --git a/src/lib/gssapi/generic/ChangeLog b/src/lib/gssapi/generic/ChangeLog index 4480d31..901410c 100644 --- a/src/lib/gssapi/generic/ChangeLog +++ b/src/lib/gssapi/generic/ChangeLog @@ -1,3 +1,8 @@ +2005-09-22 Tom Yu <tlyu@mit.edu> + + * rel_buffer.c (generic_gss_release_buffer): Free buffer even if + length is zero. This avoids memory leaks in some cases. + 2005-04-07 Tom Yu <tlyu@mit.edu> * Makefile.in (gssapi.h): Use awk hack to work around quoting diff --git a/src/lib/gssapi/generic/rel_buffer.c b/src/lib/gssapi/generic/rel_buffer.c index f5d923b..5558881 100644 --- a/src/lib/gssapi/generic/rel_buffer.c +++ b/src/lib/gssapi/generic/rel_buffer.c @@ -47,8 +47,7 @@ generic_gss_release_buffer (minor_status, if (buffer == GSS_C_NO_BUFFER) return(GSS_S_COMPLETE); - if ((buffer->length) && - (buffer->value)) { + if (buffer->value) { free(buffer->value); buffer->length = 0; buffer->value = NULL; |