diff options
| author | Tom Yu <tlyu@mit.edu> | 2002-11-07 22:43:46 +0000 |
|---|---|---|
| committer | Tom Yu <tlyu@mit.edu> | 2002-11-07 22:43:46 +0000 |
| commit | fd7141d96bf9326c3870541a431d2055e72566d1 (patch) | |
| tree | bb58a1db56f7096baec234955b2a874fa460649e /src/lib | |
| parent | 72a5933190206857aa099fe51404560e71148d9f (diff) | |
| download | krb5-fd7141d96bf9326c3870541a431d2055e72566d1.zip krb5-fd7141d96bf9326c3870541a431d2055e72566d1.tar.gz krb5-fd7141d96bf9326c3870541a431d2055e72566d1.tar.bz2 | |
rpc unit tests can fail due to race condition
The rpc unit tests can fail in fullrun.exp due to a failure to drain
output from the server in expire.exp. This commit works around the
problem by calling flush_server, but a real synchronization method
should probably be implemented, perhaps by having the server log when
a client disconnects.
* rpc_test.0/expire.exp (overlap): Add another call to
flush_server to make a race condition a little less likely. There
really should be better synchronization, as this test suite is
just full of race conditions waiting to happen.
ticket: new
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14979 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/rpc/unit-test/ChangeLog | 7 | ||||
| -rw-r--r-- | src/lib/rpc/unit-test/rpc_test.0/expire.exp | 2 |
2 files changed, 9 insertions, 0 deletions
diff --git a/src/lib/rpc/unit-test/ChangeLog b/src/lib/rpc/unit-test/ChangeLog index 273a2c2..06504cf 100644 --- a/src/lib/rpc/unit-test/ChangeLog +++ b/src/lib/rpc/unit-test/ChangeLog @@ -1,3 +1,10 @@ +2002-11-07 Tom Yu <tlyu@mit.edu> + + * rpc_test.0/expire.exp (overlap): Add another call to + flush_server to make a race condition a little less likely. There + really should be better synchronization, as this test suite is + just full of race conditions waiting to happen. + 2002-09-15 Ken Raeburn <raeburn@mit.edu> * lib/helpers.exp (setup_database): Use "!=" instead of "ne" for diff --git a/src/lib/rpc/unit-test/rpc_test.0/expire.exp b/src/lib/rpc/unit-test/rpc_test.0/expire.exp index 6f7aa93..5c33ffd 100644 --- a/src/lib/rpc/unit-test/rpc_test.0/expire.exp +++ b/src/lib/rpc/unit-test/rpc_test.0/expire.exp @@ -38,6 +38,8 @@ proc overlap {} { eof_client expire 1 $client1_id 0 eof_client expire 2 $client2_id 0 eof_client expire 3 $client3_id 0 + + flush_server } overlap |