diff options
author | Greg Hudson <ghudson@mit.edu> | 2017-07-13 12:14:20 -0400 |
---|---|---|
committer | Greg Hudson <ghudson@mit.edu> | 2017-07-24 10:40:01 -0400 |
commit | ffb35baac6981f9e8914f8f3bffd37f284b85970 (patch) | |
tree | c1ce453cc45d5a9a32539fc28de3f355a3788e58 /src/kdc/do_as_req.c | |
parent | e458441f34e47a218ce7e60fef394821fa0a934d (diff) | |
download | krb5-ffb35baac6981f9e8914f8f3bffd37f284b85970.zip krb5-ffb35baac6981f9e8914f8f3bffd37f284b85970.tar.gz krb5-ffb35baac6981f9e8914f8f3bffd37f284b85970.tar.bz2 |
Prevent KDC unset status assertion failures
Assign status values if S4U2Self padata fails to decode, if an
S4U2Proxy request uses invalid KDC options, or if an S4U2Proxy request
uses an evidence ticket which does not match the canonicalized request
server principal name. Reported by Samuel Cabrero.
If a status value is not assigned during KDC processing, default to
"UNKNOWN_REASON" rather than failing an assertion. This change will
prevent future denial of service bugs due to similar mistakes, and
will allow us to omit assigning status values for unlikely errors such
as small memory allocation failures.
CVE-2017-11368:
In MIT krb5 1.7 and later, an authenticated attacker can cause an
assertion failure in krb5kdc by sending an invalid S4U2Self or
S4U2Proxy request.
CVSSv3 Vector: AV:N/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H/E:H/RL:O/RC:C
ticket: 8599 (new)
target_version: 1.15-next
target_version: 1.14-next
tags: pullup
Diffstat (limited to 'src/kdc/do_as_req.c')
-rw-r--r-- | src/kdc/do_as_req.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/kdc/do_as_req.c b/src/kdc/do_as_req.c index 2d3ad13..9b256c8 100644 --- a/src/kdc/do_as_req.c +++ b/src/kdc/do_as_req.c @@ -366,8 +366,8 @@ finish_process_as_req(struct as_req_state *state, krb5_error_code errcode) did_log = 1; egress: - if (errcode != 0) - assert (state->status != 0); + if (errcode != 0 && state->status == NULL) + state->status = "UNKNOWN_REASON"; au_state->status = state->status; au_state->reply = &state->reply; |