diff options
| author | Ezra Peisach <epeisach@mit.edu> | 2006-06-01 03:18:19 +0000 |
|---|---|---|
| committer | Ezra Peisach <epeisach@mit.edu> | 2006-06-01 03:18:19 +0000 |
| commit | c5ac1117b5509a136aae235adc31828ac092d29f (patch) | |
| tree | 53dd5bf8a1fd3735cb1addea551c3d2954a0cfb9 /src/kdc/do_as_req.c | |
| parent | 2e376ed28688004f733853cdca98e848a77d1d39 (diff) | |
| download | krb5-c5ac1117b5509a136aae235adc31828ac092d29f.zip krb5-c5ac1117b5509a136aae235adc31828ac092d29f.tar.gz krb5-c5ac1117b5509a136aae235adc31828ac092d29f.tar.bz2 | |
krb5 1.5 alpha - memory leaks in krb5kdc due to not freeing error messages
In the kdc and lib/kadm5/logger.c, krb5_get_error_message needs to be paired
with krb5_free_error_message to release returned memory.
Essentially a memory leak was introduced for every principal requested
that did not exist in the database.
Identified by valgrind on the kdc - running kdc_hammer and specifying
more principals than are present in the db.
ticket: new
tags: pullup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18072 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src/kdc/do_as_req.c')
| -rw-r--r-- | src/kdc/do_as_req.c | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/src/kdc/do_as_req.c b/src/kdc/do_as_req.c index 1523d1f..6355e4b 100644 --- a/src/kdc/do_as_req.c +++ b/src/kdc/do_as_req.c @@ -428,23 +428,36 @@ process_as_req(krb5_kdc_req *request, const krb5_fulladdr *from, errout: if (status) { + char * emsg = 0; + if (errcode) + emsg = krb5_get_error_message (kdc_context, errcode); + krb5_klog_syslog(LOG_INFO, "AS_REQ (%s) %s: %s: %s for %s%s%s", ktypestr, fromstring, status, cname ? cname : "<unknown client>", sname ? sname : "<unknown server>", errcode ? ", " : "", - errcode ? krb5_get_error_message (kdc_context, errcode) : ""); + errcode ? emsg : ""); + if (errcode) + krb5_free_error_message (kdc_context, emsg); } if (errcode) { - if (status == 0) + int got_err = 0; + if (status == 0) { status = krb5_get_error_message (kdc_context, errcode); + got_err = 1; + } errcode -= ERROR_TABLE_BASE_krb5; if (errcode < 0 || errcode > 128) errcode = KRB_ERR_GENERIC; errcode = prepare_error_as(request, errcode, &e_data, response, status); + if (got_err) { + krb5_free_error_message (kdc_context, status); + status = 0; + } } if (encrypting_key.contents) |