diff options
| author | Robbie Harwood <rharwood@redhat.com> | 2018-12-18 15:18:13 -0500 |
|---|---|---|
| committer | Greg Hudson <ghudson@mit.edu> | 2019-01-07 01:54:33 -0500 |
| commit | 57378fb169444ee224ebc1b5d406f1b9ce562b11 (patch) | |
| tree | 855533deefb65313309b707342d5a70d8532571d | |
| parent | 56870f9456da78d77a667dfc03a6d90f948dc3a5 (diff) | |
| download | krb5-57378fb169444ee224ebc1b5d406f1b9ce562b11.zip krb5-57378fb169444ee224ebc1b5d406f1b9ce562b11.tar.gz krb5-57378fb169444ee224ebc1b5d406f1b9ce562b11.tar.bz2 | |
Fix double-close in ksu get_authorized_princ_names
If list_union() fails due to an allocation failure, then close_time()
will attempt to fclose users_fp and login_fp a second time.
This bug was originally introduced in commit
be95b52c2d0c21b1fe92f9f90166fc2fa8eecc95, and has been present in
every krb5 release since 1.1.
(cherry picked from commit 0b8c6f3e1e8e561aa56a7d4e2171320119991dae)
ticket: 8768
version_fixed: 1.16.3
| -rw-r--r-- | src/clients/ksu/heuristic.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/clients/ksu/heuristic.c b/src/clients/ksu/heuristic.c index 0d055e4..3eb28ab 100644 --- a/src/clients/ksu/heuristic.c +++ b/src/clients/ksu/heuristic.c @@ -266,7 +266,6 @@ get_authorized_princ_names(luser, cmd, princ_list) retval = list_union(k5login_list, k5users_filt_list, &combined_list); if (retval){ - close_time(k5users_flag,users_fp, k5login_flag,login_fp); return retval; } *princ_list = combined_list; |