aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTomas Kuthan <tkuthan@gmail.com>2014-04-02 17:48:04 +0200
committerGreg Hudson <ghudson@mit.edu>2014-04-04 13:59:36 -0400
commit372e4cb6f5d4a603e6e3157c7b5d354953836136 (patch)
tree5c4516f65804e4c3120eca1f5526d3607321447d
parent346883c48f1b9e09b1af2cf73e3b96ee8f934072 (diff)
downloadkrb5-372e4cb6f5d4a603e6e3157c7b5d354953836136.zip
krb5-372e4cb6f5d4a603e6e3157c7b5d354953836136.tar.gz
krb5-372e4cb6f5d4a603e6e3157c7b5d354953836136.tar.bz2
Fix leak in kadm5_flush with LDAP KDB
Due to an inverted test in adb_policy_init, kadm5_flush calls krb5_db_open twice. With the DB2 KDB module, the second open is a no-op, but with the LDAP module, a new DB handle is allocated and the old one is leaked. [ghudson@mit.edu: rewrote commit message] ticket: 7897 (new) target_version: 1.12.2 tags: pullup
-rw-r--r--src/lib/kadm5/srv/server_misc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/kadm5/srv/server_misc.c b/src/lib/kadm5/srv/server_misc.c
index 30a0b5a..18d047b 100644
--- a/src/lib/kadm5/srv/server_misc.c
+++ b/src/lib/kadm5/srv/server_misc.c
@@ -38,7 +38,7 @@ kadm5_ret_t
adb_policy_init(kadm5_server_handle_t handle)
{
/* now policy is initialized as part of database. No seperate call needed */
- if( krb5_db_inited( handle->context ) )
+ if (krb5_db_inited(handle->context) == 0)
return KADM5_OK;
return krb5_db_open( handle->context, NULL,