diff options
author | Nathaniel McCallum <npmccallum@redhat.com> | 2016-09-30 10:03:33 -0400 |
---|---|---|
committer | Greg Hudson <ghudson@mit.edu> | 2016-09-30 12:36:29 -0400 |
commit | 248497427d5a45225817b6c22e9224e8ad969872 (patch) | |
tree | 737a4b8ef2295f3113bea0aa212d8602429463dd | |
parent | f648205247da436893dae97dd7949053da927af4 (diff) | |
download | krb5-248497427d5a45225817b6c22e9224e8ad969872.zip krb5-248497427d5a45225817b6c22e9224e8ad969872.tar.gz krb5-248497427d5a45225817b6c22e9224e8ad969872.tar.bz2 |
Properly handle EOF condition on libkrad sockets
In the previous code, when the remote peer performed an orderly shutdown
on the socket, libkrad would enter a state in which all future requests
timed out. Instead, if the peer shuts down its socket, we need to
attempt to reopen it.
ticket: 8504 (new)
target_version: 1.14-next
tags: pullup
-rw-r--r-- | src/lib/krad/remote.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/lib/krad/remote.c b/src/lib/krad/remote.c index f6abc43..437f7e9 100644 --- a/src/lib/krad/remote.c +++ b/src/lib/krad/remote.c @@ -329,16 +329,15 @@ on_io_read(krad_remote *rr) /* Read the packet. */ i = recv(verto_get_fd(rr->io), rr->buffer.data + rr->buffer.length, pktlen, 0); - if (i < 0) { - /* Should we try again? */ - if (errno == EWOULDBLOCK || errno == EAGAIN || errno == EINTR) - return; - /* The socket is unrecoverable. */ + /* On these errors, try again. */ + if (i < 0 && (errno == EWOULDBLOCK || errno == EAGAIN || errno == EINTR)) + return; + + /* On any other errors or on EOF, the socket is unrecoverable. */ + if (i <= 0) { remote_shutdown(rr); return; - } else if (i == 0) { - remote_del_flags(rr, FLAGS_READ); } /* If we have a partial read or just the header, try again. */ |