diff options
| author | Nehal J Wani <nehaljw.kkd1@gmail.com> | 2018-01-28 03:02:57 -0500 |
|---|---|---|
| committer | Greg Hudson <ghudson@mit.edu> | 2018-05-01 15:31:48 -0400 |
| commit | 8420b1404f01bdfe85450d569d89c80ac499dabb (patch) | |
| tree | d784175c031914a651cd8bd7a1b1bf3b8aa43d7b | |
| parent | 07596ce5ec6a3491230b0e435b4b124473963aa8 (diff) | |
| download | krb5-8420b1404f01bdfe85450d569d89c80ac499dabb.zip krb5-8420b1404f01bdfe85450d569d89c80ac499dabb.tar.gz krb5-8420b1404f01bdfe85450d569d89c80ac499dabb.tar.bz2 | |
Always set appdefault_get() output argument
gcc 7 cannot determine that appdefault_get() always sets *ret_value
when it returns zero, so issues a "may be used uninitialized" warning
in its caller. Set *ret_value at the beginning of the function body
in accordance with current practices.
[ghudson@mit.edu: clarified commit message]
(cherry picked from commit 364c608911af2f227695bb527d4e42f091ee8bd3)
ticket: 8639
version_fixed: 1.15.3
| -rw-r--r-- | src/lib/krb5/krb/appdefault.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/lib/krb5/krb/appdefault.c b/src/lib/krb5/krb/appdefault.c index 73fd260..3f7dc23 100644 --- a/src/lib/krb5/krb/appdefault.c +++ b/src/lib/krb5/krb/appdefault.c @@ -44,6 +44,8 @@ appdefault_get(krb5_context context, const char *appname, const krb5_data *realm krb5_error_code retval; const char * realmstr = realm?realm->data:NULL; + *ret_value = NULL; + if (!context || (context->magic != KV5M_CONTEXT)) return KV5M_CONTEXT; |