aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Hudson <ghudson@mit.edu>2016-01-14 17:51:53 -0500
committerTom Yu <tlyu@mit.edu>2016-01-15 17:06:30 -0500
commitf513d6705809f30ae907059b5a367ac2718a96f6 (patch)
tree275353cfa5cf7672783442d647a96628604f272a
parent8a697b6ef9d4e528a33c66c781403698551982fc (diff)
downloadkrb5-f513d6705809f30ae907059b5a367ac2718a96f6.zip
krb5-f513d6705809f30ae907059b5a367ac2718a96f6.tar.gz
krb5-f513d6705809f30ae907059b5a367ac2718a96f6.tar.bz2
Fix iprop server stub error management
The ipropd stubs free client_name and server_name in the cleanup handler, so should not free them in out-of-memory conditions. Reported by Will Fiveash. (cherry picked from commit d998b088adb875bc0a4e13c184075f91fb23336b) ticket: 8347 version_fixed: 1.13.4 tags: -pullup status: resolved
-rw-r--r--src/kadmin/server/ipropd_svc.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/src/kadmin/server/ipropd_svc.c b/src/kadmin/server/ipropd_svc.c
index 06ecb68..802ffc2 100644
--- a/src/kadmin/server/ipropd_svc.c
+++ b/src/kadmin/server/ipropd_svc.c
@@ -160,8 +160,6 @@ iprop_get_updates_1_svc(kdb_last_t *arg, struct svc_req *rqstp)
client_name = buf_to_string(&client_desc);
service_name = buf_to_string(&service_desc);
if (client_name == NULL || service_name == NULL) {
- free(client_name);
- free(service_name);
krb5_klog_syslog(LOG_ERR,
_("%s: out of memory recording principal names"),
whoami);
@@ -288,8 +286,6 @@ ipropx_resync(uint32_t vers, struct svc_req *rqstp)
client_name = buf_to_string(&client_desc);
service_name = buf_to_string(&service_desc);
if (client_name == NULL || service_name == NULL) {
- free(client_name);
- free(service_name);
DPRINT("%s: out of memory\n", whoami);
krb5_klog_syslog(LOG_ERR,
_("%s: out of memory recording principal names"),