diff options
| author | David Benjamin <davidben@chromium.org> | 2015-02-09 19:59:14 -0500 |
|---|---|---|
| committer | Adam Langley <agl@google.com> | 2015-02-10 01:24:12 +0000 |
| commit | 722696b39e6a707b06e16d43edbd26197949a01e (patch) | |
| tree | 02ad6b73bd84aaea528a4bed7ca074169fbadec8 | |
| parent | ed3d302190d06f0fa27f9455297ec70edf804587 (diff) | |
| download | boringssl-722696b39e6a707b06e16d43edbd26197949a01e.zip boringssl-722696b39e6a707b06e16d43edbd26197949a01e.tar.gz boringssl-722696b39e6a707b06e16d43edbd26197949a01e.tar.bz2 | |
Don't lock anything in SSL_set_generate_session_id.
Nothing else on SSL* is thread-safe. (Also SSL_set_generate_session_id is never
called.) This removes the last use of CRYPTO_LOCK_SSL.
Change-Id: I4cf8c05d7cef4ea27962ce29902649317c22f74d
Reviewed-on: https://boringssl-review.googlesource.com/3361
Reviewed-by: Adam Langley <agl@google.com>
| -rw-r--r-- | ssl/ssl_lib.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c index 34fff17..87f4d7b 100644 --- a/ssl/ssl_lib.c +++ b/ssl/ssl_lib.c @@ -413,9 +413,7 @@ int SSL_CTX_set_generate_session_id(SSL_CTX *ctx, GEN_SESSION_CB cb) { } int SSL_set_generate_session_id(SSL *ssl, GEN_SESSION_CB cb) { - CRYPTO_w_lock(CRYPTO_LOCK_SSL); ssl->generate_session_id = cb; - CRYPTO_w_unlock(CRYPTO_LOCK_SSL); return 1; } |