diff options
| author | Matt Caswell <matt@openssl.org> | 2018-02-12 17:22:17 +0000 |
|---|---|---|
| committer | Matt Caswell <matt@openssl.org> | 2018-02-14 15:32:06 +0000 |
| commit | cb1c3d1a2714eb69012b079053f7fbcca1acc544 (patch) | |
| tree | d39e580de810b942d965774b29cc997e65728e82 /crypto/x509v3 | |
| parent | 62542d046483687330c55b36fa27d82dc03958c2 (diff) | |
| download | openssl-cb1c3d1a2714eb69012b079053f7fbcca1acc544.zip openssl-cb1c3d1a2714eb69012b079053f7fbcca1acc544.tar.gz openssl-cb1c3d1a2714eb69012b079053f7fbcca1acc544.tar.bz2 | |
Make sure we check the return value of extract_min_max()
Commit 42d7d7dd6 turned this function from returning void to
returning an int error code. This instance of calling it was
missed.
Found by Coverity.
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5338)
Diffstat (limited to 'crypto/x509v3')
| -rw-r--r-- | crypto/x509v3/v3_asid.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/x509v3/v3_asid.c b/crypto/x509v3/v3_asid.c index 6bc4afd..50b8816 100644 --- a/crypto/x509v3/v3_asid.c +++ b/crypto/x509v3/v3_asid.c @@ -667,7 +667,9 @@ static int asid_contains(ASIdOrRanges *parent, ASIdOrRanges *child) for (;; p++) { if (p >= sk_ASIdOrRange_num(parent)) return 0; - extract_min_max(sk_ASIdOrRange_value(parent, p), &p_min, &p_max); + if (!extract_min_max(sk_ASIdOrRange_value(parent, p), &p_min, + &p_max)) + return 0; if (ASN1_INTEGER_cmp(p_max, c_max) < 0) continue; if (ASN1_INTEGER_cmp(p_min, c_min) > 0) |