diff options
| author | David Benjamin <davidben@google.com> | 2020-01-17 16:53:56 -0500 |
|---|---|---|
| committer | Tomas Mraz <tmraz@fedoraproject.org> | 2020-01-22 18:11:30 +0100 |
| commit | 32be631ca1f2b73c92e4f7f5d23f1c3aee80ec69 (patch) | |
| tree | 96311da5899ffe99a38af33e37d95f7426e80840 /crypto/des | |
| parent | 3b740f6ec0562a97046277c8246b21163b1a7553 (diff) | |
| download | openssl-32be631ca1f2b73c92e4f7f5d23f1c3aee80ec69.zip openssl-32be631ca1f2b73c92e4f7f5d23f1c3aee80ec69.tar.gz openssl-32be631ca1f2b73c92e4f7f5d23f1c3aee80ec69.tar.bz2 | |
Do not silently truncate files on perlasm errors
If one of the perlasm xlate drivers crashes, OpenSSL's build will
currently swallow the error and silently truncate the output to however
far the driver got. This will hopefully fail to build, but better to
check such things.
Handle this by checking for errors when closing STDOUT (which is a pipe
to the xlate driver).
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/10883)
Diffstat (limited to 'crypto/des')
| -rw-r--r-- | crypto/des/asm/crypt586.pl | 2 | ||||
| -rw-r--r-- | crypto/des/asm/des-586.pl | 2 | ||||
| -rw-r--r-- | crypto/des/asm/dest4-sparcv9.pl | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/crypto/des/asm/crypt586.pl b/crypto/des/asm/crypt586.pl index b611b4e..def4e7f 100644 --- a/crypto/des/asm/crypt586.pl +++ b/crypto/des/asm/crypt586.pl @@ -24,7 +24,7 @@ $R="esi"; &fcrypt_body("fcrypt_body"); &asm_finish(); -close STDOUT; +close STDOUT or die "error closing STDOUT"; sub fcrypt_body { diff --git a/crypto/des/asm/des-586.pl b/crypto/des/asm/des-586.pl index 483f195..45fe3d2 100644 --- a/crypto/des/asm/des-586.pl +++ b/crypto/des/asm/des-586.pl @@ -46,7 +46,7 @@ $small_footprint=1 if (grep(/\-DOPENSSL_SMALL_FOOTPRINT/,@ARGV)); &asm_finish(); -close STDOUT; +close STDOUT or die "error closing STDOUT"; sub DES_encrypt_internal() { diff --git a/crypto/des/asm/dest4-sparcv9.pl b/crypto/des/asm/dest4-sparcv9.pl index 0cf25ad..90438f0 100644 --- a/crypto/des/asm/dest4-sparcv9.pl +++ b/crypto/des/asm/dest4-sparcv9.pl @@ -623,4 +623,4 @@ ___ &emit_assembler(); -close STDOUT; +close STDOUT or die "error closing STDOUT"; |