diff options
| author | Dr. Stephen Henson <steve@openssl.org> | 2012-02-28 14:47:02 +0000 |
|---|---|---|
| committer | Dr. Stephen Henson <steve@openssl.org> | 2012-02-28 14:47:02 +0000 |
| commit | dc4f678cdc12beeef9d501f32468681ac775fd76 (patch) | |
| tree | ed3eee5fea9abde39f4e51f27c455862ccac95fe /crypto/asn1/x_pubkey.c | |
| parent | 0f2ece872d6603cda01ed5c0e333b41d28f8c67f (diff) | |
| download | openssl-dc4f678cdc12beeef9d501f32468681ac775fd76.zip openssl-dc4f678cdc12beeef9d501f32468681ac775fd76.tar.gz openssl-dc4f678cdc12beeef9d501f32468681ac775fd76.tar.bz2 | |
Fix memory leak cause by race condition when creating public keys.
Thanks to Ivan Nestlerode <inestlerode@us.ibm.com> for reporting this bug.
Diffstat (limited to 'crypto/asn1/x_pubkey.c')
| -rw-r--r-- | crypto/asn1/x_pubkey.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/crypto/asn1/x_pubkey.c b/crypto/asn1/x_pubkey.c index d42b6a2..627ec87 100644 --- a/crypto/asn1/x_pubkey.c +++ b/crypto/asn1/x_pubkey.c @@ -171,7 +171,16 @@ EVP_PKEY *X509_PUBKEY_get(X509_PUBKEY *key) goto error; } - key->pkey = ret; + /* Check to see if another thread set key->pkey first */ + CRYPTO_w_lock(CRYPTO_LOCK_EVP_PKEY); + if (key->pkey) + { + EVP_PKEY_free(ret); + ret = key->pkey; + } + else + key->pkey = ret; + CRYPTO_w_unlock(CRYPTO_LOCK_EVP_PKEY); CRYPTO_add(&ret->references, 1, CRYPTO_LOCK_EVP_PKEY); return ret; |