aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt Caswell <matt@openssl.org>2016-05-17 11:07:27 +0100
committerMatt Caswell <matt@openssl.org>2016-05-17 14:27:19 +0100
commit2647e2617e31002cb0ab80758be4e566917d2888 (patch)
tree55f6fa7cb91002efa106b2935e65faacc8776dc5
parentc0e32b16099e346c3289932a6494c5fc902429d1 (diff)
downloadopenssl-2647e2617e31002cb0ab80758be4e566917d2888.zip
openssl-2647e2617e31002cb0ab80758be4e566917d2888.tar.gz
openssl-2647e2617e31002cb0ab80758be4e566917d2888.tar.bz2
Remove repeated condition from if in X509_NAME_oneline
An if checks the value of |type| to see if it is V_ASN1_VISIBLESTRING twice. We only need to do it once. GitHub Issue #656 Reviewed-by: Richard Levitte <levitte@openssl.org>
-rw-r--r--crypto/x509/x509_obj.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/x509/x509_obj.c b/crypto/x509/x509_obj.c
index eaa03f2..1297307 100644
--- a/crypto/x509/x509_obj.c
+++ b/crypto/x509/x509_obj.c
@@ -129,7 +129,7 @@ char *X509_NAME_oneline(X509_NAME *a, char *buf, int len)
type == V_ASN1_VISIBLESTRING ||
type == V_ASN1_PRINTABLESTRING ||
type == V_ASN1_TELETEXSTRING ||
- type == V_ASN1_VISIBLESTRING || type == V_ASN1_IA5STRING) {
+ type == V_ASN1_IA5STRING) {
if (num > (int)sizeof(ebcdic_buf))
num = sizeof(ebcdic_buf);
ascii2ebcdic(ebcdic_buf, q, num);