Cygwin: open: Fix Windows resource leak after fd exhaustionHEADgithub/mastergithub/mainmastermain

In a specific rare case when a Cygwin process runs out of available
file descriptor numbers (errno set to EMFILE), the underlying Windows
HANDLE is not being closed. This is partly because currently the given
file is first opened natively before a new Cygwin file descriptor has
been assigned - the logic overlooks the fact that it is possible for
the Windows HANDLE to be valid, but not the internal fd.

Even though the object is explicitly freed from memory later using
operator delete, the fhandler_disk_file class has no destructor
defined to mitigate the leak.

This patch introduces a manual call to fh->close() if the assigned fd
value returned by the operator int &() function in the cygheap_fdnew
class is less than 0.

Test fixed on AArch64 and x86_64:
winsup.api/ltp/dup03.exe

Signed-off-by: Igor Podgainoi <Igor.Podgainoi@arm.com>

0 files changed, 0 insertions, 0 deletions