diff options
| author | Ken Brown <kbrown@cornell.edu> | 2022-05-22 11:43:44 -0400 |
|---|---|---|
| committer | Ken Brown <kbrown@cornell.edu> | 2022-05-23 08:16:40 -0400 |
| commit | 2f8ba4004675ff13741dcfd7de2014bec6834ca3 (patch) | |
| tree | e8e83a54caed789623b0d76bb914f99f76e147b9 | |
| parent | 03e815a91b1a1f94ce0cfd6ff64f50ae40ed740c (diff) | |
| download | newlib-2f8ba4004675ff13741dcfd7de2014bec6834ca3.zip newlib-2f8ba4004675ff13741dcfd7de2014bec6834ca3.tar.gz newlib-2f8ba4004675ff13741dcfd7de2014bec6834ca3.tar.bz2 | |
Cygwin: fix mknod (64-bit only)
The current definition of mknod in syscalls.cc has a third argument of
type __dev16_t instead of dev_t. Fix this on 64-bit Cygwin by making
the existing mknod 32-bit only and then exporting mknod as an alias
for mknod32. (No fix is needed on 32-bit because mknod is redirected
to mknod32 via NEW_FUNCTIONS in Makefile.am.)
Addresses: https://cygwin.com/pipermail/cygwin-developers/2022-May/012589.html
| -rw-r--r-- | winsup/cygwin/release/3.3.6 | 3 | ||||
| -rw-r--r-- | winsup/cygwin/syscalls.cc | 4 |
2 files changed, 7 insertions, 0 deletions
diff --git a/winsup/cygwin/release/3.3.6 b/winsup/cygwin/release/3.3.6 index 6d72243..135f331 100644 --- a/winsup/cygwin/release/3.3.6 +++ b/winsup/cygwin/release/3.3.6 @@ -7,3 +7,6 @@ Bug Fixes - Fix killpg failing because the exec'ing as well as the exec'ed process are not in the pidlist for a brief moment. Addresses: https://cygwin.com/pipermail/cygwin/2022-May/251479.html + +- Fix mknod (64-bit only), whose definition didn't match its prototype. + Addresses: https://cygwin.com/pipermail/cygwin-developers/2022-May/012589.html diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc index 3a652c4..344d1d3 100644 --- a/winsup/cygwin/syscalls.cc +++ b/winsup/cygwin/syscalls.cc @@ -3490,11 +3490,15 @@ mknod32 (const char *path, mode_t mode, dev_t dev) return -1; } +#ifdef __i386__ extern "C" int mknod (const char *_path, mode_t mode, __dev16_t dev) { return mknod32 (_path, mode, (dev_t) dev); } +#else +EXPORT_ALIAS (mknod32, mknod) +#endif extern "C" int mkfifo (const char *path, mode_t mode) |