diff options
author | Rich Felker <dalias@aerifal.cx> | 2011-03-28 01:14:44 -0400 |
---|---|---|
committer | Rich Felker <dalias@aerifal.cx> | 2011-03-28 01:14:44 -0400 |
commit | e3cd6c5c265cd481db6e0c5b529855d99f0bda30 (patch) | |
tree | 85d2c586e4ea8e261ed68cc4b1901a1711774441 /src/stdio/vfprintf.c | |
parent | ea343364a719add2cd8adf8a50c15bb5f9400dd8 (diff) | |
download | musl-e3cd6c5c265cd481db6e0c5b529855d99f0bda30.zip musl-e3cd6c5c265cd481db6e0c5b529855d99f0bda30.tar.gz musl-e3cd6c5c265cd481db6e0c5b529855d99f0bda30.tar.bz2 |
major stdio overhaul, using readv/writev, plus other changes
the biggest change in this commit is that stdio now uses readv to fill
the caller's buffer and the FILE buffer with a single syscall, and
likewise writev to flush the FILE buffer and write out the caller's
buffer in a single syscall.
making this change required fundamental architectural changes to
stdio, so i also made a number of other improvements in the process:
- the implementation no longer assumes that further io will fail
following errors, and no longer blocks io when the error flag is set
(though the latter could easily be changed back if desired)
- unbuffered mode is no longer implemented as a one-byte buffer. as a
consequence, scanf unreading has to use ungetc, to the unget buffer
has been enlarged to hold at least 2 wide characters.
- the FILE structure has been rearranged to maintain the locations of
the fields that might be used in glibc getc/putc type macros, while
shrinking the structure to save some space.
- error cases for fflush, fseek, etc. should be more correct.
- library-internal macros are used for getc_unlocked and putc_unlocked
now, eliminating some ugly code duplication. __uflow and __overflow
are no longer used anywhere but these macros. switch to read or
write mode is also separated so the code can be better shared, e.g.
with ungetc.
- lots of other small things.
Diffstat (limited to 'src/stdio/vfprintf.c')
-rw-r--r-- | src/stdio/vfprintf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/stdio/vfprintf.c b/src/stdio/vfprintf.c index b6bb3bc..57878c0 100644 --- a/src/stdio/vfprintf.c +++ b/src/stdio/vfprintf.c @@ -434,7 +434,7 @@ static int printf_core(FILE *f, const char *fmt, va_list *ap, union arg *nl_arg, /* Update output count, end loop when fmt is exhausted */ if (cnt >= 0) { if (l > INT_MAX - cnt) { - if (!ferror(f)) errno = EOVERFLOW; + errno = EOVERFLOW; cnt = -1; } else cnt += l; } |