From 3f3930a451e118e82885a6dd20e3918427b816c2 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 25 Jul 2022 23:00:59 -0700 Subject: Remove redundaunt virtual specifiers (NFC) Identified with tidy-modernize-use-override. --- polly/include/polly/CodeGen/BlockGenerators.h | 7 +++---- polly/include/polly/CodeGen/LoopGeneratorsGOMP.h | 2 +- polly/include/polly/CodeGen/LoopGeneratorsKMP.h | 2 +- polly/include/polly/ScopPass.h | 2 +- polly/lib/CodeGen/CodegenCleanup.cpp | 8 ++++---- polly/lib/Support/DumpFunctionPass.cpp | 4 ++-- polly/lib/Support/DumpModulePass.cpp | 4 ++-- polly/lib/Transform/DeLICM.cpp | 8 ++++---- polly/lib/Transform/FlattenSchedule.cpp | 8 ++++---- polly/lib/Transform/Simplify.cpp | 8 ++++---- 10 files changed, 26 insertions(+), 27 deletions(-) (limited to 'polly') diff --git a/polly/include/polly/CodeGen/BlockGenerators.h b/polly/include/polly/CodeGen/BlockGenerators.h index 1fc5a4c..a30eb8b 100644 --- a/polly/include/polly/CodeGen/BlockGenerators.h +++ b/polly/include/polly/CodeGen/BlockGenerators.h @@ -974,7 +974,7 @@ private: /// @param BBMap A mapping from old values to their new values in this block. /// @param LTS A mapping from loops virtual canonical induction variable to /// their new values. - virtual void + void generateScalarStores(ScopStmt &Stmt, LoopToScevMapT <S, ValueMapT &BBMAp, __isl_keep isl_id_to_ast_expr *NewAccesses) override; @@ -988,9 +988,8 @@ private: /// @param BBMap A mapping from old values to their new values /// (for values recalculated within this basic block). /// @param LTS A map from old loops to new induction variables as SCEVs. - virtual void copyPHIInstruction(ScopStmt &Stmt, PHINode *Inst, - ValueMapT &BBMap, - LoopToScevMapT <S) override; + void copyPHIInstruction(ScopStmt &Stmt, PHINode *Inst, ValueMapT &BBMap, + LoopToScevMapT <S) override; }; } // namespace polly #endif diff --git a/polly/include/polly/CodeGen/LoopGeneratorsGOMP.h b/polly/include/polly/CodeGen/LoopGeneratorsGOMP.h index 83d9b4b..4cc4f39 100644 --- a/polly/include/polly/CodeGen/LoopGeneratorsGOMP.h +++ b/polly/include/polly/CodeGen/LoopGeneratorsGOMP.h @@ -47,7 +47,7 @@ public: void deployParallelExecution(Function *SubFn, Value *SubFnParam, Value *LB, Value *UB, Value *Stride) override; - virtual Function *prepareSubFnDefinition(Function *F) const override; + Function *prepareSubFnDefinition(Function *F) const override; std::tuple createSubFn(Value *Stride, AllocaInst *Struct, SetVector UsedValues, diff --git a/polly/include/polly/CodeGen/LoopGeneratorsKMP.h b/polly/include/polly/CodeGen/LoopGeneratorsKMP.h index 9a7c7561..245a63c7 100644 --- a/polly/include/polly/CodeGen/LoopGeneratorsKMP.h +++ b/polly/include/polly/CodeGen/LoopGeneratorsKMP.h @@ -73,7 +73,7 @@ public: void deployParallelExecution(Function *SubFn, Value *SubFnParam, Value *LB, Value *UB, Value *Stride) override; - virtual Function *prepareSubFnDefinition(Function *F) const override; + Function *prepareSubFnDefinition(Function *F) const override; std::tuple createSubFn(Value *Stride, AllocaInst *Struct, SetVector UsedValues, diff --git a/polly/include/polly/ScopPass.h b/polly/include/polly/ScopPass.h index c9d325a..144cfd1 100644 --- a/polly/include/polly/ScopPass.h +++ b/polly/include/polly/ScopPass.h @@ -175,7 +175,7 @@ protected: /// getAnalysisUsage - Subclasses that override getAnalysisUsage /// must call this. /// - virtual void getAnalysisUsage(AnalysisUsage &AU) const override; + void getAnalysisUsage(AnalysisUsage &AU) const override; private: bool runOnRegion(Region *R, RGPassManager &RGM) override; diff --git a/polly/lib/CodeGen/CodegenCleanup.cpp b/polly/lib/CodeGen/CodegenCleanup.cpp index 6ecb1f4..100bc93 100644 --- a/polly/lib/CodeGen/CodegenCleanup.cpp +++ b/polly/lib/CodeGen/CodegenCleanup.cpp @@ -40,9 +40,9 @@ public: /// @name FunctionPass interface //@{ - virtual void getAnalysisUsage(llvm::AnalysisUsage &AU) const override {} + void getAnalysisUsage(llvm::AnalysisUsage &AU) const override {} - virtual bool doInitialization(Module &M) override { + bool doInitialization(Module &M) override { assert(!FPM); FPM = new llvm::legacy::FunctionPassManager(&M); @@ -106,7 +106,7 @@ public: return FPM->doInitialization(); } - virtual bool doFinalization(Module &M) override { + bool doFinalization(Module &M) override { bool Result = FPM->doFinalization(); delete FPM; @@ -115,7 +115,7 @@ public: return Result; } - virtual bool runOnFunction(llvm::Function &F) override { + bool runOnFunction(llvm::Function &F) override { if (!F.hasFnAttribute("polly-optimized")) { LLVM_DEBUG( dbgs() << F.getName() diff --git a/polly/lib/Support/DumpFunctionPass.cpp b/polly/lib/Support/DumpFunctionPass.cpp index 9256f12..b4a10ab 100644 --- a/polly/lib/Support/DumpFunctionPass.cpp +++ b/polly/lib/Support/DumpFunctionPass.cpp @@ -100,11 +100,11 @@ public: /// @name FunctionPass interface //@{ - virtual void getAnalysisUsage(llvm::AnalysisUsage &AU) const override { + void getAnalysisUsage(llvm::AnalysisUsage &AU) const override { AU.setPreservesAll(); } - virtual bool runOnFunction(llvm::Function &F) override { + bool runOnFunction(llvm::Function &F) override { runDumpFunction(F, Suffix); return false; } diff --git a/polly/lib/Support/DumpModulePass.cpp b/polly/lib/Support/DumpModulePass.cpp index 5df74b2..c1c27ef 100644 --- a/polly/lib/Support/DumpModulePass.cpp +++ b/polly/lib/Support/DumpModulePass.cpp @@ -71,11 +71,11 @@ public: /// @name ModulePass interface //@{ - virtual void getAnalysisUsage(llvm::AnalysisUsage &AU) const override { + void getAnalysisUsage(llvm::AnalysisUsage &AU) const override { AU.setPreservesAll(); } - virtual bool runOnModule(llvm::Module &M) override { + bool runOnModule(llvm::Module &M) override { runDumpModule(M, Filename, IsSuffix); return false; } diff --git a/polly/lib/Transform/DeLICM.cpp b/polly/lib/Transform/DeLICM.cpp index 9948e08..51e7013 100644 --- a/polly/lib/Transform/DeLICM.cpp +++ b/polly/lib/Transform/DeLICM.cpp @@ -1428,13 +1428,13 @@ public: static char ID; explicit DeLICMWrapperPass() : ScopPass(ID) {} - virtual void getAnalysisUsage(AnalysisUsage &AU) const override { + void getAnalysisUsage(AnalysisUsage &AU) const override { AU.addRequiredTransitive(); AU.addRequired(); AU.setPreservesAll(); } - virtual bool runOnScop(Scop &S) override { + bool runOnScop(Scop &S) override { // Free resources for previous scop's computation, if not yet done. releaseMemory(); @@ -1444,7 +1444,7 @@ public: return Impl->isModified(); } - virtual void printScop(raw_ostream &OS, Scop &S) const override { + void printScop(raw_ostream &OS, Scop &S) const override { if (!Impl) return; assert(Impl->getScop() == &S); @@ -1453,7 +1453,7 @@ public: Impl->print(OS); } - virtual void releaseMemory() override { Impl.reset(); } + void releaseMemory() override { Impl.reset(); } }; char DeLICMWrapperPass::ID; diff --git a/polly/lib/Transform/FlattenSchedule.cpp b/polly/lib/Transform/FlattenSchedule.cpp index 27de81f..53e230b 100644 --- a/polly/lib/Transform/FlattenSchedule.cpp +++ b/polly/lib/Transform/FlattenSchedule.cpp @@ -47,12 +47,12 @@ public: static char ID; explicit FlattenSchedule() : ScopPass(ID) {} - virtual void getAnalysisUsage(AnalysisUsage &AU) const override { + void getAnalysisUsage(AnalysisUsage &AU) const override { AU.addRequiredTransitive(); AU.setPreservesAll(); } - virtual bool runOnScop(Scop &S) override { + bool runOnScop(Scop &S) override { // Keep a reference to isl_ctx to ensure that it is not freed before we free // OldSchedule. IslCtx = S.getSharedIslCtx(); @@ -79,7 +79,7 @@ public: return false; } - virtual void printScop(raw_ostream &OS, Scop &S) const override { + void printScop(raw_ostream &OS, Scop &S) const override { OS << "Schedule before flattening {\n"; printSchedule(OS, OldSchedule, 4); OS << "}\n\n"; @@ -89,7 +89,7 @@ public: OS << "}\n"; } - virtual void releaseMemory() override { + void releaseMemory() override { OldSchedule = {}; IslCtx.reset(); } diff --git a/polly/lib/Transform/Simplify.cpp b/polly/lib/Transform/Simplify.cpp index f6cbfce..27e865a 100644 --- a/polly/lib/Transform/Simplify.cpp +++ b/polly/lib/Transform/Simplify.cpp @@ -762,13 +762,13 @@ public: explicit SimplifyWrapperPass(int CallNo = 0) : ScopPass(ID), CallNo(CallNo) {} - virtual void getAnalysisUsage(AnalysisUsage &AU) const override { + void getAnalysisUsage(AnalysisUsage &AU) const override { AU.addRequiredTransitive(); AU.addRequired(); AU.setPreservesAll(); } - virtual bool runOnScop(Scop &S) override { + bool runOnScop(Scop &S) override { LoopInfo *LI = &getAnalysis().getLoopInfo(); Impl.emplace(CallNo); @@ -777,12 +777,12 @@ public: return false; } - virtual void printScop(raw_ostream &OS, Scop &S) const override { + void printScop(raw_ostream &OS, Scop &S) const override { if (Impl) Impl->printScop(OS, S); } - virtual void releaseMemory() override { Impl.reset(); } + void releaseMemory() override { Impl.reset(); } }; char SimplifyWrapperPass::ID; -- cgit v1.1