From 988faf87f8067646431dca3e238147f316d84bcb Mon Sep 17 00:00:00 2001 From: Vedant Kumar Date: Wed, 18 Oct 2017 18:52:27 +0000 Subject: [llvm-cov] Highlight gaps in consecutive uncovered regions llvm-cov typically doesn't highlight gap segments, but it should if the gap occurs after an uncovered region in order to preserve continuity. llvm-svn: 316107 --- llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp') diff --git a/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp b/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp index 40e194c..3372e97 100644 --- a/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp +++ b/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp @@ -506,7 +506,7 @@ void SourceCoverageViewHTML::renderLine( // 1 to set the highlight for snippet 2, segment 2 to set the highlight for // snippet 3, and so on. - Optional Color; + Optional Color; SmallVector, 2> HighlightedRanges; auto Highlight = [&](const std::string &Snippet, unsigned LC, unsigned RC) { if (getOptions().Debug) @@ -528,7 +528,8 @@ void SourceCoverageViewHTML::renderLine( const auto *CurSeg = Segments[I]; if (CurSeg->Col == ExpansionCol) Color = "cyan"; - else if (!CurSeg->IsGapRegion && CheckIfUncovered(CurSeg)) + else if ((!CurSeg->IsGapRegion || (Color && *Color == "red")) && + CheckIfUncovered(CurSeg)) Color = "red"; else Color = None; -- cgit v1.1