From 70841b97eb2e5c68d46b70579877e378511a47b4 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 23 Jun 2022 08:08:36 -0700 Subject: [lldb] Make thread safety the responsibility of the log handlers Drop the thread-safe flag and make the locking strategy the responsibility of the individual log handler. Previously we got away with a non-thread safe mode because we were using unbuffered streams that rely on the underlying syscalls/OS for synchronization. With the introduction of log handlers, we can have arbitrary logic involved in writing out the logs. With this patch the log handlers can pick the most appropriate locking strategy for their particular implementation. Differential revision: https://reviews.llvm.org/D127922 --- lldb/source/Commands/CommandObjectLog.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'lldb/source/Commands/CommandObjectLog.cpp') diff --git a/lldb/source/Commands/CommandObjectLog.cpp b/lldb/source/Commands/CommandObjectLog.cpp index 190b262..91277e3 100644 --- a/lldb/source/Commands/CommandObjectLog.cpp +++ b/lldb/source/Commands/CommandObjectLog.cpp @@ -94,9 +94,6 @@ public: error = buffer_size.SetValueFromString(option_arg, eVarSetOperationAssign); break; - case 't': - log_options |= LLDB_LOG_OPTION_THREADSAFE; - break; case 'v': log_options |= LLDB_LOG_OPTION_VERBOSE; break; -- cgit v1.1