From e2a885537f11f8d9ced1c80c2c90069ab5adeb1d Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 22 May 2025 12:44:20 -0700 Subject: Revert "[clang] Remove intrusive reference count from `DiagnosticOptions` (#139584)" This reverts commit 9e306ad4600c4d3392c194a8be88919ee758425c. Multiple builtbot failures have been reported: https://github.com/llvm/llvm-project/pull/139584 --- clang/unittests/Interpreter/InterpreterTest.cpp | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'clang/unittests/Interpreter/InterpreterTest.cpp') diff --git a/clang/unittests/Interpreter/InterpreterTest.cpp b/clang/unittests/Interpreter/InterpreterTest.cpp index b97f5ae..03b9c33 100644 --- a/clang/unittests/Interpreter/InterpreterTest.cpp +++ b/clang/unittests/Interpreter/InterpreterTest.cpp @@ -95,9 +95,8 @@ TEST_F(InterpreterTest, Errors) { // Create the diagnostic engine with unowned consumer. std::string DiagnosticOutput; llvm::raw_string_ostream DiagnosticsOS(DiagnosticOutput); - DiagnosticOptions DiagOpts; - auto DiagPrinter = - std::make_unique(DiagnosticsOS, DiagOpts); + auto DiagPrinter = std::make_unique( + DiagnosticsOS, new DiagnosticOptions()); auto Interp = createInterpreter(ExtraArgs, DiagPrinter.get()); auto Err = Interp->Parse("intentional_error v1 = 42; ").takeError(); @@ -127,9 +126,8 @@ TEST_F(InterpreterTest, DeclsAndStatements) { // Create the diagnostic engine with unowned consumer. std::string DiagnosticOutput; llvm::raw_string_ostream DiagnosticsOS(DiagnosticOutput); - DiagnosticOptions DiagOpts; - auto DiagPrinter = - std::make_unique(DiagnosticsOS, DiagOpts); + auto DiagPrinter = std::make_unique( + DiagnosticsOS, new DiagnosticOptions()); auto Interp = createInterpreter(ExtraArgs, DiagPrinter.get()); auto R1 = Interp->Parse( @@ -150,9 +148,8 @@ TEST_F(InterpreterTest, UndoCommand) { // Create the diagnostic engine with unowned consumer. std::string DiagnosticOutput; llvm::raw_string_ostream DiagnosticsOS(DiagnosticOutput); - DiagnosticOptions DiagOpts; - auto DiagPrinter = - std::make_unique(DiagnosticsOS, DiagOpts); + auto DiagPrinter = std::make_unique( + DiagnosticsOS, new DiagnosticOptions()); auto Interp = createInterpreter(ExtraArgs, DiagPrinter.get()); -- cgit v1.1