From 90828e00a09c4e6687d93d1bd6cb24f29e9a8bb5 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Tue, 24 Jun 2025 10:44:15 -0700 Subject: [CIR] Restore the underscore in dso_local (#145551) The CIR handling of `dso_local` for globals was upstreamed without the underscore, making it inconsistent with the incubator and LLVM IR. This change restores the underscore. --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'clang/lib') diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 5d95c6e..a870e6c 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -1032,7 +1032,7 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( mlir::ConversionPatternRewriter &rewriter) const { cir::FuncType fnType = op.getFunctionType(); - assert(!cir::MissingFeatures::opFuncDsolocal()); + assert(!cir::MissingFeatures::opFuncDsoLocal()); bool isDsoLocal = false; mlir::TypeConverter::SignatureConversion signatureConversion( fnType.getNumInputs()); @@ -1119,7 +1119,7 @@ void CIRToLLVMGlobalOpLowering::setupRegionInitializedLLVMGlobalOp( const bool isConst = false; assert(!cir::MissingFeatures::addressSpace()); const unsigned addrSpace = 0; - const bool isDsoLocal = op.getDsolocal(); + const bool isDsoLocal = op.getDsoLocal(); assert(!cir::MissingFeatures::opGlobalThreadLocal()); const bool isThreadLocal = false; const uint64_t alignment = op.getAlignment().value_or(0); @@ -1173,7 +1173,7 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( const bool isConst = false; assert(!cir::MissingFeatures::addressSpace()); const unsigned addrSpace = 0; - const bool isDsoLocal = op.getDsolocal(); + const bool isDsoLocal = op.getDsoLocal(); assert(!cir::MissingFeatures::opGlobalThreadLocal()); const bool isThreadLocal = false; const uint64_t alignment = op.getAlignment().value_or(0); -- cgit v1.1