From 6963309af12f8d1a688fa2c42019d83e78a0024c Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 16 May 2025 20:02:50 -0700 Subject: [Frontend] Avoid creating a temporary instance of std::string (NFC) (#140326) Since getLastArgValue returns StringRef, and the constructor of SmallString accepts StringRef, we do not need to go through a temporary instance of std::string. --- clang/lib/Frontend/CompilerInvocation.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'clang/lib/Frontend/CompilerInvocation.cpp') diff --git a/clang/lib/Frontend/CompilerInvocation.cpp b/clang/lib/Frontend/CompilerInvocation.cpp index fd48e42..3c23073 100644 --- a/clang/lib/Frontend/CompilerInvocation.cpp +++ b/clang/lib/Frontend/CompilerInvocation.cpp @@ -2055,8 +2055,7 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions &Opts, ArgList &Args, // The memory profile runtime appends the pid to make this name more unique. const char *MemProfileBasename = "memprof.profraw"; if (Args.hasArg(OPT_fmemory_profile_EQ)) { - SmallString<128> Path( - std::string(Args.getLastArgValue(OPT_fmemory_profile_EQ))); + SmallString<128> Path(Args.getLastArgValue(OPT_fmemory_profile_EQ)); llvm::sys::path::append(Path, MemProfileBasename); Opts.MemoryProfileOutput = std::string(Path); } else if (Args.hasArg(OPT_fmemory_profile)) -- cgit v1.1