From 09e794c4bb138e14b3156d7dbdac0164d9c0327b Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 19 Jun 2025 07:47:03 -0500 Subject: [HIP] Emit the CUID value in the module with the new driver (#144570) Summary: This is a weird point of divergence that was not updated when the new driver switched to using the CUID method, which is also apparently critical for SPIR-V compilation not failing? Somehow if we don't emit this global than the `llvm.compiler.used` global uses AS(0) which makes SPIR-V unhappy, but with this global it's AS(4) which makes it happy. Either way, this should be fixed. --- clang/lib/CodeGen/CodeGenModule.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'clang/lib/CodeGen/CodeGenModule.cpp') diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index c27168e..1668881 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -969,7 +969,7 @@ void CodeGenModule::Release() { llvm::ConstantArray::get(ATy, UsedArray), "__clang_gpu_used_external"); addCompilerUsedGlobal(GV); } - if (LangOpts.HIP && !getLangOpts().OffloadingNewDriver) { + if (LangOpts.HIP) { // Emit a unique ID so that host and device binaries from the same // compilation unit can be associated. auto *GV = new llvm::GlobalVariable( -- cgit v1.1