From 1bccbe1f49abc39b9f980cf3f1b171da5541d1a4 Mon Sep 17 00:00:00 2001
From: martinboehme <mboehme@google.com>
Date: Wed, 17 Apr 2024 08:17:56 +0200
Subject: [clang][dataflow] Treat `BuiltinBitCastExpr` correctly in
 `PropagateResultObject()`. (#88875)

This patch includes a test that assert-fails without the fix.
---
 clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

(limited to 'clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp')

diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
index f2b4a67..3f1600d 100644
--- a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
+++ b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
@@ -419,7 +419,11 @@ public:
     // below them can initialize the same object (or part of it).
     if (isa<CXXConstructExpr>(E) || isa<CallExpr>(E) || isa<LambdaExpr>(E) ||
         isa<CXXDefaultArgExpr>(E) || isa<CXXDefaultInitExpr>(E) ||
-        isa<CXXStdInitializerListExpr>(E)) {
+        isa<CXXStdInitializerListExpr>(E) ||
+        // We treat `BuiltinBitCastExpr` as an "original initializer" too as
+        // it may not even be casting from a record type -- and even if it is,
+        // the two objects are in general of unrelated type.
+        isa<BuiltinBitCastExpr>(E)) {
       return;
     }
     if (auto *Op = dyn_cast<BinaryOperator>(E);
-- 
cgit v1.1