From 93fecc2577ece0329f3bbe2719bbc5b4b9b30010 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 31 Jul 2024 17:51:06 +0400 Subject: [lldb] Fixed lldb-server crash (TestLogHandler was not thread safe) (#101326) Host::LaunchProcess() requires to SetMonitorProcessCallback. This callback is called from the child process monitor thread. We cannot control this thread anyway. lldb-server may crash if there is a logging around this callback because TestLogHandler is not thread safe. I faced this issue debugging 100 simultaneous child processes. Note StreamLogHandler::Emit() in lldb/source/Utility/Log.cpp already contains the similar mutex. --- lldb/tools/lldb-server/LLDBServerUtilities.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lldb/tools/lldb-server/LLDBServerUtilities.cpp b/lldb/tools/lldb-server/LLDBServerUtilities.cpp index c3a8df1..5facfbf 100644 --- a/lldb/tools/lldb-server/LLDBServerUtilities.cpp +++ b/lldb/tools/lldb-server/LLDBServerUtilities.cpp @@ -27,11 +27,13 @@ public: : m_stream_sp(stream_sp) {} void Emit(llvm::StringRef message) override { + std::lock_guard guard(m_mutex); (*m_stream_sp) << message; m_stream_sp->flush(); } private: + std::mutex m_mutex; std::shared_ptr m_stream_sp; }; -- cgit v1.1