aboutsummaryrefslogtreecommitdiff
path: root/openmp/runtime/src
AgeCommit message (Collapse)AuthorFilesLines
2017-11-27Merging r318848:Tom Stellard1-1/+8
------------------------------------------------------------------------ r318848 | hahnfeld | 2017-11-22 09:15:20 -0800 (Wed, 22 Nov 2017) | 7 lines Fix for OMP doacross implementation on Power Power has a weak consistency model so we need memory barriers to make writes (both from runtime and from user code) available for all threads. Differential Revision: https://reviews.llvm.org/D40175 ------------------------------------------------------------------------ llvm-svn: 319057
2017-11-27Merging r318658:Tom Stellard1-8/+15
------------------------------------------------------------------------ r318658 | achurbanov | 2017-11-20 08:00:42 -0800 (Mon, 20 Nov 2017) | 4 lines Fixed OMP doacross implementation on 32-bit platforms. Differential Revision: https://reviews.llvm.org/D40171 ------------------------------------------------------------------------ llvm-svn: 319053
2017-11-14Merging r317115:Tom Stellard1-3/+4
------------------------------------------------------------------------ r317115 | jlpeyton | 2017-11-01 12:44:42 -0700 (Wed, 01 Nov 2017) | 19 lines [OpenMP] Fix race condition in omp_init_lock This is a partial fix for bug 34050. This prevents callers of omp_set_lock (which does not hold __kmp_global_lock) from ever seeing an uninitialized version of __kmp_i_lock_table.table. It does not solve a use-after-free race condition if omp_set_lock obtains a pointer to __kmp_i_lock_table.table before it is updated and then attempts to dereference afterwards. That race is far less likely and can be handled in a separate patch. The unit test usually segfaults on the current trunk revision. It passes with the patch. Patch by Adam Azarchs Differential Revision: https://reviews.llvm.org/D39439 ------------------------------------------------------------------------ llvm-svn: 318178
2017-11-14Merging r316452:Tom Stellard1-0/+7
------------------------------------------------------------------------ r316452 | jlpeyton | 2017-10-24 09:10:09 -0700 (Tue, 24 Oct 2017) | 9 lines Disable threadprivate data cleanup if runtime is terminating The problem is due to the runtime's threadprivate cleanup code which tries to access data that was already destroyed by one of the root threads. __kmp_init_gtid is used as a checker here since it is set to false before actual resource cleanup is done in __kmp_cleanup(). Patch by Hansang Bae ------------------------------------------------------------------------ llvm-svn: 318176
2017-11-14Merging r311269:Tom Stellard1-1/+1
------------------------------------------------------------------------ r311269 | jlpeyton | 2017-08-19 16:53:36 -0700 (Sat, 19 Aug 2017) | 8 lines Use va_copy instead of __va_copy to fix building libomp against musl libc Fixes https://bugs.llvm.org/show_bug.cgi?id=34040 Patch by Peter Levine Differential Revision: https://reviews.llvm.org/D36343 ------------------------------------------------------------------------ llvm-svn: 318175
2017-11-14Merging r309875:Tom Stellard1-3/+2
------------------------------------------------------------------------ r309875 | jlpeyton | 2017-08-02 13:06:32 -0700 (Wed, 02 Aug 2017) | 11 lines Move lock acquire/release functions in task deque cleanup code The original locations can be reached without initializing the lock variable (td_deque_lock), so it is potentially unsafe. It is guaranteed that the lock is initialized if the deque (td_deque) is not NULL, and lock functions can be safely called. Patch by Hansang Bae Differential Revision: https://reviews.llvm.org/D36017 ------------------------------------------------------------------------ llvm-svn: 318171
2017-07-19OpenMP RTL cleanup: two PAUSEs per spin loop iteration replaced with single oneAndrey Churbanov2-6/+13
Differential Revision: https://reviews.llvm.org/D35490 llvm-svn: 308423
2017-07-18For KMP_PAGE_SIZE, use getpagesize() on Unix, GetSystemInfo() on WindowsDimitry Andric1-8/+8
Summary: The kmp_os.h header is defining the `PAGE_SIZE` macro unconditionally, even while it is only used directly after its definition, for the Windows implementation of the `KMP_GET_PAGE_SIZE()` macro. On at least FreeBSD, but likely all other BSDs too, this macro conflicts with the one defined in system headers, so remove it, since nothing else uses it. Make all Unixes use `getpagesize()` instead, and use `GetSystemInfo()` for the Windows case. Reviewers: jlpeyton, jcownie, emaste, AndreyChurbanov Reviewed By: AndreyChurbanov Subscribers: AndreyChurbanov, hfinkel, zturner Differential Revision: https://reviews.llvm.org/D35072 llvm-svn: 308355
2017-07-18Add recursive task scheduling strategy to taskloop implementationJonathan Peyton4-95/+308
Summary: Taskloop implementation is extended by using recursive task scheduling. Envirable KMP_TASKLOOP_MIN_TASKS added as a manual threshold for the user to switch from recursive to linear tasks scheduling. Details: * The calculations for the loop parameters are moved from __kmp_taskloop_linear upper level * Initial calculation is done in the __kmpc_taskloop, further range splitting is done in the __kmp_taskloop_recur. * Added threshold to switch from recursive to linear tasks scheduling; * One half of split range is scheduled as an internal task which just moves sub-range parameters to the stealing thread that continues recursive scheduling (if number of tasks still enough), the other half is processed recursively; * Internal task duplication routine fixed to assign parent task, that was not needed when all tasks were scheduled by same thread, but is needed now. Patch by Andrey Churbanov Differential Revision: https://reviews.llvm.org/D35273 llvm-svn: 308338
2017-07-18Fix sporadic segfaults in tasking tests.Andrey Churbanov1-1/+1
Patch by Terry Wilmarth Differential Revision: https://reviews.llvm.org/D35535 llvm-svn: 308298
2017-07-18OpenMP RTL cleanup: nullify pointer after memory freeingAndrey Churbanov1-1/+4
Differential Revision: https://reviews.llvm.org/D35497 llvm-svn: 308274
2017-07-17Removed "duplicates" from verbose affinity outputJonathan Peyton1-5/+0
The internal details of this setting are not meant to be user visible and only create confusion. Differential Revision: https://reviews.llvm.org/D35269 llvm-svn: 308189
2017-07-17OpenMP RTL cleanup: eliminated warnings with -Wcast-qual, patch 2.Andrey Churbanov16-215/+244
Changes are: got all atomics to accept volatile pointers that allowed to simplify many type conversions. Windows specific code fixed correspondingly. Differential Revision: https://reviews.llvm.org/D35417 llvm-svn: 308164
2017-07-13[GOMP] Fix (un)tied tasks with the GCCJonas Hahnfeld1-2/+2
The first bit is actually the "untied" flag. That is why the condition was wrong and has to be inverted to set the flag correctly. Found and initial patch by Simon Convent! llvm-svn: 307899
2017-07-11Rename z_Linux_asm.s to z_Linux_asm.SDimitry Andric2-3/+3
Summary: On Unix, a .S file is normally an assembly source which must be preprocessed with a C preprocessor, while a .s file is "plain" assembly. The former is handled by the compiler driver (cc), the latter is directly passed to the assembler binary (as). Because z_Linux_asm.s is supposed to be preprocessed, rename it to .S, so it can be automatically picked up correctly by build systems. Reviewers: AndreyChurbanov, emaste, jlpeyton Reviewed By: AndreyChurbanov Subscribers: mgorny, openmp-commits Differential Revision: https://reviews.llvm.org/D35171 llvm-svn: 307680
2017-07-07remove deprecated register storage class specifierEd Maste7-148/+148
While importing libomp into the FreeBSD base system we encountered Clang warnings that "'register' storage class specifier is deprecated and incompatible with C++1z [-Wdeprecated-register]". Differential Revision: https://reviews.llvm.org/D35124 llvm-svn: 307441
2017-07-07remove duplicate symbol version script entriesEd Maste1-3/+0
GNU ld ignores duplicates, but lld produces a warning. Differential Revision: https://reviews.llvm.org/D35121 llvm-svn: 307399
2017-07-05Fix wrong website in messagesJonathan Peyton1-2/+2
Address user message bug where the messages were sending users to Intel's website instead of the LLVM OpenMP runtime websites. Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=32892 Differential Revision: https://reviews.llvm.org/D35018 llvm-svn: 307206
2017-07-03OpenMP RTL cleanup: eliminated warnings with -Wcast-qual.Andrey Churbanov22-349/+376
Changes are: replaced C-style casts with cons_cast and reinterpret_cast; type of several counters changed to signed; type of parameters of 32-bit and 64-bit AND and OR intrinsics changes to unsigned; changed files formatted using clang-format version 3.8.1. Differential Revision: https://reviews.llvm.org/D34759 llvm-svn: 307020
2017-06-15Set affinity to none/false in child processesJonathan Peyton1-1/+12
Reset affinity to none (false for proc-bind-var) so that threads in the child processes are not bound tightly, unless the user explicitly sets this in KMP_AFFINITY/OMP_PROC_BIND, in child processes. This can improve performance for scripting languages which fork for parallelism like Python's multiprocessing module. Differential Revision: https://reviews.llvm.org/D34154 llvm-svn: 305513
2017-06-13Replace platform macro with KMP_MIC_SUPPORTEDJonathan Peyton5-15/+19
Differential Revision: https://reviews.llvm.org/D34119 llvm-svn: 305307
2017-06-13Reset initial affinity in children processesJonathan Peyton2-0/+9
If OpenMP is initialized before fork()-ing occurs and affinity is set to something like compact, then the master thread will be pinned to a single HW thread/core after initialization. If the master (or any other thread) then forks N processes, all N processes will then be pinned to that same single HW thread/core. To reset the affinity for the new child process, the atfork handler for the child process can call kmp_set_thread_affinity_mask_initial() to reset its affinity to the initial affinity of the application before it re-initializes libomp. The parent process will not be affected and still keeps its affinity setting. Differential Revision: https://reviews.llvm.org/D34118 llvm-svn: 305306
2017-06-06Fix static initializers for locks.Jonathan Peyton1-4/+5
Fix static initializers to use the proper unlocked value for the poll field of the tas and futex locks. Patch by Terry Wilmarth Differential Revision: https://reviews.llvm.org/D33794 llvm-svn: 304828
2017-06-05OpenMP 4.5: implemented support of schedule(simd:guided) andAndrey Churbanov3-3/+132
schedule(simd:runtime) - library part. Compiler generation should use newly introduced scheduling kinds kmp_sch_guided_simd = 46, kmp_sch_runtime_simd = 47, as parameters to __kmpc_dispatch_init_* entries. Differential Revision: https://reviews.llvm.org/D31602 llvm-svn: 304724
2017-06-01Re-enable assertion after the problem that caused it to be hit had been fixedAndrey Churbanov1-5/+0
Differential Revision: https://reviews.llvm.org/D31421 llvm-svn: 304443
2017-06-01Fix minor formatting issuesJonathan Peyton4-35/+27
Some code was restructured to move it under KMP_DEBUG. The rest is formatting changes to fix some things broken by clang-format Patch by Terry Wilmarth Differential Revision: https://reviews.llvm.org/D33744 llvm-svn: 304438
2017-05-31Fix for KMP_AFFINITY=disabled and KMP_TOPOLOGY_METHOD=hwlocJonathan Peyton2-1/+14
With these settings, the create_hwloc_map() method was being called causing an assert(). After some consideration, it was determined that disabling affinity explicitly should just disable hwloc as well. i.e., KMP_AFFINITY overrides KMP_TOPOLOGY_METHOD. This lets the user know that the Hwloc mechanism is being ignored when KMP_AFFINITY=disabled. Differential Revision: https://reviews.llvm.org/D33208 llvm-svn: 304344
2017-05-31Address default pinning OpenMP process with multiple processor groupsJonathan Peyton1-2/+30
This change checks if the initial affinity mask is equal to exactly one Windows processor group's affinity mask. If it is, then the code does not respect the initial affinity mask and uses the entire machine instead. The reasoning behind this is that, by default, Windows assigns exactly one processor group as the initial affinity mask even when there are multiple Windows processor groups available. User's typically want to use the whole machine, so we ignore this special case and use the entire machine. If the initial affinity mask is a proper subset of one group, or spans multiple groups, then the initial affinity mask is respected since we can assume that the operating system did not assign this initial affinity mask. This change only affects machines with multiple processor groups Differential Revision: https://reviews.llvm.org/D33210 llvm-svn: 304343
2017-05-15Fix for KMP_AFFINITY=respect with multiple processor groupsJonathan Peyton1-3/+2
An assert() was being tripped when KMP_AFFINITY=respect + Multiple Processor Groups. Let __kmp_affinity_create_proc_group_map() function be able to create address2os object which contains a single group by deleting restriction that process affinity mask must span multiple groups. llvm-svn: 303101
2017-05-15Remove some outdated commentsJonathan Peyton1-11/+0
llvm-svn: 303086
2017-05-12Clang-format and whitespace cleanup of source codeJonathan Peyton75-54486/+53500
This patch contains the clang-format and cleanup of the entire code base. Some of clang-formats changes made the code look worse in places. A best effort was made to resolve the bulk of these problems, but many remain. Most of the problems were mangling line-breaks and tabbing of comments. Patch by Terry Wilmarth Differential Revision: https://reviews.llvm.org/D32659 llvm-svn: 302929
2017-04-25Fix Hwloc API IncompatibilityJonathan Peyton2-5/+11
Older Hwloc libraries (< 1.10.0) don't offer the HWLOC_OBJ_NUMANODE nor HWLOC_OBJ_PACKAGE types. Instead they are named HWLOC_OBJ_NODE and HWLOC_OBJ_SOCKET instead. This patch just defines the newer names based on the older names when using an older Hwloc. Differential Revision: https://reviews.llvm.org/D32496 llvm-svn: 301349
2017-04-25[OpenMP] Add missing parenthesis which triggers a compile errorGeorge Rokos1-1/+1
Differential Revision: https://reviews.llvm.org/D32490 llvm-svn: 301318
2017-04-17Fix crash in invoking microtask on ios arm64.Andrey Churbanov2-5/+26
Patch by Ni Hui. Differential Revision: https://reviews.llvm.org/D31923 llvm-svn: 300448
2017-04-13KMP_HW_SUBSET extended with NUMA support when HWLOC enabledAndrey Churbanov7-380/+834
Differential Revision: https://reviews.llvm.org/D31600 llvm-svn: 300220
2017-04-04Reset cancellation status for 'parallel', 'sections' and 'for' constracts.Olga Malysheva2-0/+10
Without this fix cancellation status for parallel, sections and for persists across construct boundaries. Differential Revision: https://reviews.llvm.org/D31419 llvm-svn: 299434
2017-04-04Test check-in, comment changedOlga Malysheva1-1/+2
llvm-svn: 299428
2017-03-28Fix for bug https://llvm.org/bugs/show_bug.cgi?id=30889Andrey Churbanov1-1/+1
Condition adjusted for Debug assertion. Differential Revision: https://reviews.llvm.org/D29638 llvm-svn: 298915
2017-03-23GOMP compatibility: add missing OpenMP4.0 task deps handling codePaul Osmialowski1-1/+22
Differential Revision: https://reviews.llvm.org/D31071 llvm-svn: 298605
2017-03-21Fixed intermittent hang on tests with "target teams if(0)" construct with no ↵Andrey Churbanov1-6/+10
parallel inside. Differential Revision: https://reviews.llvm.org/D29597 llvm-svn: 298373
2017-03-21Stride in distribute parallel for loops with no chunk size.Andrey Churbanov1-0/+1
Patch by George Rokos. Differential Revision: https://reviews.llvm.org/D24486 llvm-svn: 298362
2017-03-20Minor improvement of KMP_YIELD_NOW() macro.Jonathan Peyton2-7/+11
This change slightly improves performance of KMP_YIELD_NOW() macro, by using _rdtsc() intrinsic function if possible. Patch by Hansang Bae Differential Revision: https://reviews.llvm.org/D31008 llvm-svn: 298314
2017-03-20Fix incorrect initial value of __kmp_affinity_type.Jonathan Peyton1-0/+1
Affinity initialization code expects __kmp_affinity_type has the value affinity_default by default, but the cleanup code does not properly set the value back to affinity_default. This may introduce some issues when multiple roots are trying to initialize/uninitialize the runtime successively. Patch by Hansang Bae Differential Revision: https://reviews.llvm.org/D31012 llvm-svn: 298313
2017-03-10Fix assertion failure when 'proclist' is used without 'explicit' in KMP_AFFINITYJonathan Peyton1-2/+5
This change fixes an assertion failure the in case KMP_AFFINITY is set with 'proclist' specified but without 'explicit' e.g., KMP_AFFINITY=verbose,proclist=[0-31] Patch by Olga Malysheva Differential Revision: https://reviews.llvm.org/D30404 llvm-svn: 297480
2017-03-07Fix GNU strerror_r check for Android.Dan Albert1-1/+3
Summary: Bionic didn't get a GNU style strerror_r until Android M. Until then we unconditionally exposed the POSIX one. Expand the check to account for this. Reviewers: pirama, AndreyChurbanov, jlpeyton Reviewed By: jlpeyton Subscribers: openmp-commits, srhines Differential Revision: https://reviews.llvm.org/D30056 llvm-svn: 297235
2017-03-06OpenMP version 5.0 addedJonathan Peyton7-2/+2742
Add build option LIBOMP_OMP_VERSION=50, 5.0 headers, and add the year/month associated with OpenMP 5.0 in relevant source locations. Also, remove the deprecated LIBOMP_OMP_VERSION=41 option. Patch by Olga Malysheva Differential Revision: https://reviews.llvm.org/D30450 llvm-svn: 297083
2017-03-06Mixed type atomic routines added to Windows DLLJonathan Peyton2-0/+8
Patch by Olga Malysheva Differential Revision: https://reviews.llvm.org/D30408 llvm-svn: 297082
2017-02-28Removing couple unnecessary architecture guards.Jonathan Peyton1-2/+2
This section of code (__kmp_test_then_* functions) is guarded by (KMP_ARCH_X86 || KMP_ARCH_X86_64) so it does not make sense to have other architecture guards inside this section. Non-x86 architectures always use intrinsics (__sync_*) llvm-svn: 296525
2017-02-22[OpenMP] Missing virtual destructor in KMPAffinityGeorge Rokos1-0/+2
Added virtual destructor in a class containing virtual functions. Differential Revision: https://reviews.llvm.org/D30271 llvm-svn: 295896
2017-02-17[stats] add stats-gathering for static_steal scheduling methodJonathan Peyton2-0/+8
Add counter to count number of static_steal for loops Add counter for number of chunks executed per static_steal for loop Add counter for number of chunks stolen per static_steal for loop llvm-svn: 295461
generated by cgit v1.1 at 2024-09-07 11:32:47 +0000