diff options
| author | Jordan Rupprecht <rupprecht@google.com> | 2024-03-04 23:00:04 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-04 21:00:04 -0800 |
| commit | d016712b2cbeecf13c0d558c7c8932fd66e14847 (patch) | |
| tree | 974f213de7172003efb710f74aa46801fc3f1be7 /utils | |
| parent | cec2073f8e82c2d72a7246300aaa7b2a85ca4012 (diff) | |
| download | llvm-d016712b2cbeecf13c0d558c7c8932fd66e14847.zip llvm-d016712b2cbeecf13c0d558c7c8932fd66e14847.tar.gz llvm-d016712b2cbeecf13c0d558c7c8932fd66e14847.tar.bz2 | |
[bzl] Remove obsolete `output_to_genfiles = True` (#83944)
The [bazel docs](https://bazel.build/rules/lib/globals/bzl#rule)
discourage setting this. The comments about being necessary for headers
or genrules seem to be obsolete, at least for the LLVM tree itself.
The effect of this is that generated files will go to `bazel-bin`
instead of `bazel-genfiles`.
One external use was fixed here:
https://github.com/google/jax/commit/32bb3b06132b4256cd8674fb98bce057dc968610.
Diffstat (limited to 'utils')
| -rw-r--r-- | utils/bazel/llvm-project-overlay/llvm/enum_targets_gen.bzl | 2 | ||||
| -rw-r--r-- | utils/bazel/llvm-project-overlay/mlir/tblgen.bzl | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/utils/bazel/llvm-project-overlay/llvm/enum_targets_gen.bzl b/utils/bazel/llvm-project-overlay/llvm/enum_targets_gen.bzl index 998b706..7961749 100644 --- a/utils/bazel/llvm-project-overlay/llvm/enum_targets_gen.bzl +++ b/utils/bazel/llvm-project-overlay/llvm/enum_targets_gen.bzl @@ -64,7 +64,5 @@ enum_targets_gen = rule( " `@LLVM_ENUM_{macro_name}S@`", ), }, - # output_to_genfiles is required for header files. - output_to_genfiles = True, implementation = enum_targets_gen_impl, ) diff --git a/utils/bazel/llvm-project-overlay/mlir/tblgen.bzl b/utils/bazel/llvm-project-overlay/mlir/tblgen.bzl index 9d26822..fdf6a57 100644 --- a/utils/bazel/llvm-project-overlay/mlir/tblgen.bzl +++ b/utils/bazel/llvm-project-overlay/mlir/tblgen.bzl @@ -181,8 +181,6 @@ def _gentbl_rule_impl(ctx): gentbl_rule = rule( _gentbl_rule_impl, doc = "Generates tabular code from a table definition file.", - # Match genrule behavior - output_to_genfiles = True, attrs = { "tblgen": attr.label( doc = "The TableGen executable with which to generate `out`.", |