diff options
| author | Hans Wennborg <hans@chromium.org> | 2023-11-28 12:28:03 +0100 |
|---|---|---|
| committer | Hans Wennborg <hans@chromium.org> | 2023-11-28 12:28:59 +0100 |
| commit | ea640472a2f1b851a5edf653c5257767d7fedd70 (patch) | |
| tree | 75fafe0bc42fba5e007aa03f88453561ca2a9026 /runtimes/CMakeLists.txt | |
| parent | 2a8040e8f6639b5bf35b65c7e881de4b4ca8742f (diff) | |
| download | llvm-ea640472a2f1b851a5edf653c5257767d7fedd70.zip llvm-ea640472a2f1b851a5edf653c5257767d7fedd70.tar.gz llvm-ea640472a2f1b851a5edf653c5257767d7fedd70.tar.bz2 | |
Revert "[llvm] Disable HandleLLVMOptions in runtimes mode (#73031)"
This appears to have caused a variety of breakages, see comments on the PR.
> Summary:
> There are a few default options that LLVM adds that can be problematic
> for runtimes builds. These options are generally intended to handle
> building LLVM itself, but are also added when building in a runtimes
> mode. One such issue I've run into is that in `libc` we deliberately use
> `--target` to use a different device toolchain, which doesn't support
> some linker arguments passed via `-Wl`. This is observed in
> https://github.com/llvm/llvm-project/pull/73030 when attempting to use
> these options.
>
> This patch completely removes these default arguments.
>
> The consensus is that any issues created by this patch should ultimately
> be solved on a per-runtime basis.
This reverts commit ee922e6ebfb6aab722f6b0f7cfc0c20af636a250.
Diffstat (limited to 'runtimes/CMakeLists.txt')
| -rw-r--r-- | runtimes/CMakeLists.txt | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/runtimes/CMakeLists.txt b/runtimes/CMakeLists.txt index 603a328..010ec87 100644 --- a/runtimes/CMakeLists.txt +++ b/runtimes/CMakeLists.txt @@ -151,7 +151,9 @@ endif() # Avoid checking whether the compiler is working. set(LLVM_COMPILER_CHECKED ON) +# Handle common options used by all runtimes. include(AddLLVM) +include(HandleLLVMOptions) find_package(Python3 REQUIRED COMPONENTS Interpreter) |