diff options
author | Matthias Springer <me@m-sp.org> | 2024-01-19 10:20:41 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-01-19 10:20:41 +0100 |
commit | 4fc128f817b425657049922175619addb04c8f41 (patch) | |
tree | c7d0178a55128e3917461497d68b4a53d8f64c77 /mlir | |
parent | 805035931ececce8a856f31c576e8565ba078f93 (diff) | |
download | llvm-4fc128f817b425657049922175619addb04c8f41.zip llvm-4fc128f817b425657049922175619addb04c8f41.tar.gz llvm-4fc128f817b425657049922175619addb04c8f41.tar.bz2 |
[mlir][bufferization][NFC] Clean up code (#78594)
Clean up code and remove dead code.
Diffstat (limited to 'mlir')
3 files changed, 2 insertions, 18 deletions
diff --git a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h index 63e2d19..226a2fb 100644 --- a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h +++ b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h @@ -375,9 +375,6 @@ struct BufferizationOptions { SmallVector<AnalysisStateInitFn> stateInitializers; }; -/// Return `true` if the given value is a BlockArgument of a func::FuncOp. -bool isFunctionArgument(Value value); - /// Traversal parameters for `findValueInReverseUseDefChain`. struct TraversalConfig { /// Specifies if leaves (that do not have further OpOperands to follow) diff --git a/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp b/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp index 4b1dfee..6ca9702 100644 --- a/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp +++ b/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp @@ -759,13 +759,6 @@ LogicalResult BufferizationOptions::createMemCpy(OpBuilder &b, Location loc, // Bufferization-specific IRMapping support with debugging. //===----------------------------------------------------------------------===// -bool bufferization::isFunctionArgument(Value value) { - auto bbArg = llvm::dyn_cast<BlockArgument>(value); - if (!bbArg) - return false; - return isa<func::FuncOp>(bbArg.getOwner()->getParentOp()); -} - BaseMemRefType bufferization::getMemRefType(Value value, const BufferizationOptions &options, MemRefLayoutAttrInterface layout, diff --git a/mlir/lib/Dialect/Bufferization/Transforms/BufferDeallocationSimplification.cpp b/mlir/lib/Dialect/Bufferization/Transforms/BufferDeallocationSimplification.cpp index 75d6519..4d1e21c 100644 --- a/mlir/lib/Dialect/Bufferization/Transforms/BufferDeallocationSimplification.cpp +++ b/mlir/lib/Dialect/Bufferization/Transforms/BufferDeallocationSimplification.cpp @@ -240,13 +240,6 @@ struct RemoveRetainedMemrefsGuaranteedToNotAlias LogicalResult matchAndRewrite(DeallocOp deallocOp, PatternRewriter &rewriter) const override { SmallVector<Value> newRetainedMemrefs, replacements; - Value falseValue; - auto getOrCreateFalse = [&]() -> Value { - if (!falseValue) - falseValue = rewriter.create<arith::ConstantOp>( - deallocOp.getLoc(), rewriter.getBoolAttr(false)); - return falseValue; - }; for (auto retainedMemref : deallocOp.getRetained()) { if (potentiallyAliasesMemref(aliasAnalysis, deallocOp.getMemrefs(), @@ -256,7 +249,8 @@ struct RemoveRetainedMemrefsGuaranteedToNotAlias continue; } - replacements.push_back(getOrCreateFalse()); + replacements.push_back(rewriter.create<arith::ConstantOp>( + deallocOp.getLoc(), rewriter.getBoolAttr(false))); } if (newRetainedMemrefs.size() == deallocOp.getRetained().size()) |