diff options
| author | Mehdi Amini <joker.eph@gmail.com> | 2024-02-25 20:47:08 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-25 20:47:08 -0800 |
| commit | e5332482c6009699d7b66393617a389d8ae62710 (patch) | |
| tree | 4b903d3e91c1f1563172585e9d23aa9c2f93cf6c /mlir/test/Target | |
| parent | ce4da0c4ee6e414ddb771d45b68bc7e31b12970e (diff) | |
| download | llvm-e5332482c6009699d7b66393617a389d8ae62710.zip llvm-e5332482c6009699d7b66393617a389d8ae62710.tar.gz llvm-e5332482c6009699d7b66393617a389d8ae62710.tar.bz2 | |
[MLIR][Spirv] Use StringAttr for linkage_name (NFC) (#82953)
std::string was used here, likely by mistake. The usual convention for
attributes is to use StringAttr.
Diffstat (limited to 'mlir/test/Target')
| -rw-r--r-- | mlir/test/Target/SPIRV/decorations.mlir | 2 | ||||
| -rw-r--r-- | mlir/test/Target/SPIRV/function-decorations.mlir | 2 | ||||
| -rw-r--r-- | mlir/test/Target/SPIRV/global-variable.mlir | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/mlir/test/Target/SPIRV/decorations.mlir b/mlir/test/Target/SPIRV/decorations.mlir index d215c33..e8f75a1 100644 --- a/mlir/test/Target/SPIRV/decorations.mlir +++ b/mlir/test/Target/SPIRV/decorations.mlir @@ -59,7 +59,7 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> { // ----- spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, Linkage], []> { - // CHECK: linkage_attributes = #spirv.linkage_attributes<linkage_name = outSideGlobalVar1, linkage_type = <Import>> + // CHECK: linkage_attributes = #spirv.linkage_attributes<linkage_name = "outSideGlobalVar1", linkage_type = <Import>> spirv.GlobalVariable @var1 { linkage_attributes=#spirv.linkage_attributes< linkage_name="outSideGlobalVar1", diff --git a/mlir/test/Target/SPIRV/function-decorations.mlir b/mlir/test/Target/SPIRV/function-decorations.mlir index 117d4ca..ef62714 100644 --- a/mlir/test/Target/SPIRV/function-decorations.mlir +++ b/mlir/test/Target/SPIRV/function-decorations.mlir @@ -8,7 +8,7 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, Linkage], []> { spirv.FunctionCall @outside.func.with.linkage(%uchar_0):(i8) -> () spirv.Return } - // CHECK: linkage_attributes = #spirv.linkage_attributes<linkage_name = outside.func, linkage_type = <Import>> + // CHECK: linkage_attributes = #spirv.linkage_attributes<linkage_name = "outside.func", linkage_type = <Import>> spirv.func @outside.func.with.linkage(%arg0 : i8) -> () "Pure" attributes { linkage_attributes=#spirv.linkage_attributes< linkage_name="outside.func", diff --git a/mlir/test/Target/SPIRV/global-variable.mlir b/mlir/test/Target/SPIRV/global-variable.mlir index f22d2a9..28b2706 100644 --- a/mlir/test/Target/SPIRV/global-variable.mlir +++ b/mlir/test/Target/SPIRV/global-variable.mlir @@ -62,7 +62,7 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> { // ----- spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, Linkage], []> { - // CHECK: linkage_attributes = #spirv.linkage_attributes<linkage_name = outSideGlobalVar1, linkage_type = <Import>> + // CHECK: linkage_attributes = #spirv.linkage_attributes<linkage_name = "outSideGlobalVar1", linkage_type = <Import>> spirv.GlobalVariable @var1 { linkage_attributes=#spirv.linkage_attributes< linkage_name="outSideGlobalVar1", |