aboutsummaryrefslogtreecommitdiff
path: root/llvm/unittests/Analysis/ValueTrackingTest.cpp
diff options
context:
space:
mode:
authorMatt Arsenault <Matthew.Arsenault@amd.com>2023-10-05 13:10:28 -0700
committerGitHub <noreply@github.com>2023-10-05 13:10:28 -0700
commit7a46baa465c49db84b7b5f8fa9ab847ec1da3ce4 (patch)
tree6c2ff97fa82d55bc81036ecafd7a9123136a6f3e /llvm/unittests/Analysis/ValueTrackingTest.cpp
parenta6acf3fd49a20c570a390af2a3c84e10b9545b68 (diff)
downloadllvm-7a46baa465c49db84b7b5f8fa9ab847ec1da3ce4.zip
llvm-7a46baa465c49db84b7b5f8fa9ab847ec1da3ce4.tar.gz
llvm-7a46baa465c49db84b7b5f8fa9ab847ec1da3ce4.tar.bz2
ValueTracking: Use fcAllFlags for unknown value (#66393)
In the failure case we return null, which callers are checking. We were also returning an fcNone which was unused. It's more consistent to return fcAllFlags as any possible value, such that the value is always directly usable without checking the returned value.
Diffstat (limited to 'llvm/unittests/Analysis/ValueTrackingTest.cpp')
-rw-r--r--llvm/unittests/Analysis/ValueTrackingTest.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/llvm/unittests/Analysis/ValueTrackingTest.cpp b/llvm/unittests/Analysis/ValueTrackingTest.cpp
index 4eed22d..5bd1bb3 100644
--- a/llvm/unittests/Analysis/ValueTrackingTest.cpp
+++ b/llvm/unittests/Analysis/ValueTrackingTest.cpp
@@ -1848,13 +1848,13 @@ TEST_F(ComputeKnownFPClassTest, FCmpToClassTest_NInf) {
fcmpToClassTest(CmpInst::FCMP_OGT, *A3->getFunction(), A3->getOperand(0),
A3->getOperand(1));
EXPECT_EQ(nullptr, OgtVal);
- EXPECT_EQ(fcNone, OgtClass);
+ EXPECT_EQ(fcAllFlags, OgtClass);
auto [UleVal, UleClass] =
fcmpToClassTest(CmpInst::FCMP_ULE, *A4->getFunction(), A4->getOperand(0),
A4->getOperand(1));
EXPECT_EQ(nullptr, UleVal);
- EXPECT_EQ(fcNone, UleClass);
+ EXPECT_EQ(fcAllFlags, UleClass);
}
TEST_F(ComputeKnownFPClassTest, FCmpToClassTest_PInf) {
@@ -1881,13 +1881,13 @@ TEST_F(ComputeKnownFPClassTest, FCmpToClassTest_PInf) {
fcmpToClassTest(CmpInst::FCMP_OLE, *A3->getFunction(), A3->getOperand(0),
A3->getOperand(1));
EXPECT_EQ(nullptr, OleVal);
- EXPECT_EQ(fcNone, OleClass);
+ EXPECT_EQ(fcAllFlags, OleClass);
auto [UgtVal, UgtClass] =
fcmpToClassTest(CmpInst::FCMP_UGT, *A4->getFunction(), A4->getOperand(0),
A4->getOperand(1));
EXPECT_EQ(nullptr, UgtVal);
- EXPECT_EQ(fcNone, UgtClass);
+ EXPECT_EQ(fcAllFlags, UgtClass);
}
TEST_F(ComputeKnownFPClassTest, SqrtNszSignBit) {