diff options
author | Tom Weaver <Tom.Weaver@Sony.com> | 2023-09-08 13:41:11 +0100 |
---|---|---|
committer | Tom Weaver <Tom.Weaver@Sony.com> | 2023-09-08 13:41:11 +0100 |
commit | 4871a9ca54674be336a800f207652b8737a76d71 (patch) | |
tree | 791c4d3cb22898471997832ce4c573feb50ab038 /llvm/tools/llvm-jitlink | |
parent | feb7beaf70bace1c3ffafc7f732c8fadca5e8c9d (diff) | |
download | llvm-4871a9ca54674be336a800f207652b8737a76d71.zip llvm-4871a9ca54674be336a800f207652b8737a76d71.tar.gz llvm-4871a9ca54674be336a800f207652b8737a76d71.tar.bz2 |
Revert "[jitlink/rtdydl][checker] Add TargetFlag dependent disassembler switching support"
This reverts commit 4b17c81d5a5d3e0f514026c2b7f9b623d901cc04.
Caused buildbot failures:
https://lab.llvm.org/buildbot/#/builders/230/builds/18341
https://lab.llvm.org/buildbot/#/builders/109/builds/73169
https://lab.llvm.org/buildbot/#/builders/67/builds/12597
Diffstat (limited to 'llvm/tools/llvm-jitlink')
-rw-r--r-- | llvm/tools/llvm-jitlink/llvm-jitlink-coff.cpp | 11 | ||||
-rw-r--r-- | llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp | 11 | ||||
-rw-r--r-- | llvm/tools/llvm-jitlink/llvm-jitlink-macho.cpp | 13 | ||||
-rw-r--r-- | llvm/tools/llvm-jitlink/llvm-jitlink.cpp | 14 |
4 files changed, 21 insertions, 28 deletions
diff --git a/llvm/tools/llvm-jitlink/llvm-jitlink-coff.cpp b/llvm/tools/llvm-jitlink/llvm-jitlink-coff.cpp index 283e655..415aee7 100644 --- a/llvm/tools/llvm-jitlink/llvm-jitlink-coff.cpp +++ b/llvm/tools/llvm-jitlink/llvm-jitlink-coff.cpp @@ -118,8 +118,7 @@ Error registerCOFFGraphInfo(Session &S, LinkGraph &G) { if (Sym->getSize() != 0) { if (auto TS = getCOFFGOTTarget(G, Sym->getBlock())) FileInfo.GOTEntryInfos[TS->getName()] = { - Sym->getSymbolContent(), Sym->getAddress().getValue(), - Sym->getTargetFlags()}; + Sym->getSymbolContent(), Sym->getAddress().getValue()}; else return TS.takeError(); } @@ -131,8 +130,7 @@ Error registerCOFFGraphInfo(Session &S, LinkGraph &G) { if (auto TS = getCOFFStubTarget(G, Sym->getBlock())) FileInfo.StubInfos[TS->getName()] = {Sym->getSymbolContent(), - Sym->getAddress().getValue(), - Sym->getTargetFlags()}; + Sym->getAddress().getValue()}; else return TS.takeError(); SectionContainsContent = true; @@ -145,8 +143,7 @@ Error registerCOFFGraphInfo(Session &S, LinkGraph &G) { SectionContainsZeroFill = true; } else { S.SymbolInfos[Sym->getName()] = {Sym->getSymbolContent(), - Sym->getAddress().getValue(), - Sym->getTargetFlags()}; + Sym->getAddress().getValue()}; SectionContainsContent = true; } } @@ -167,7 +164,7 @@ Error registerCOFFGraphInfo(Session &S, LinkGraph &G) { else FileInfo.SectionInfos[Sec.getName()] = { ArrayRef<char>(FirstSym->getBlock().getContent().data(), SecSize), - SecAddr.getValue(), FirstSym->getTargetFlags()}; + SecAddr.getValue()}; } return Error::success(); diff --git a/llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp b/llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp index 7881660..5200dbc 100644 --- a/llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp +++ b/llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp @@ -120,8 +120,7 @@ Error registerELFGraphInfo(Session &S, LinkGraph &G) { if (Sym->getSize() != 0) { if (auto TS = getELFGOTTarget(G, Sym->getBlock())) FileInfo.GOTEntryInfos[TS->getName()] = { - Sym->getSymbolContent(), Sym->getAddress().getValue(), - Sym->getTargetFlags()}; + Sym->getSymbolContent(), Sym->getAddress().getValue()}; else return TS.takeError(); } @@ -133,8 +132,7 @@ Error registerELFGraphInfo(Session &S, LinkGraph &G) { if (auto TS = getELFStubTarget(G, Sym->getBlock())) FileInfo.StubInfos[TS->getName()] = {Sym->getSymbolContent(), - Sym->getAddress().getValue(), - Sym->getTargetFlags()}; + Sym->getAddress().getValue()}; else return TS.takeError(); SectionContainsContent = true; @@ -147,8 +145,7 @@ Error registerELFGraphInfo(Session &S, LinkGraph &G) { SectionContainsZeroFill = true; } else { S.SymbolInfos[Sym->getName()] = {Sym->getSymbolContent(), - Sym->getAddress().getValue(), - Sym->getTargetFlags()}; + Sym->getAddress().getValue()}; SectionContainsContent = true; } } @@ -173,7 +170,7 @@ Error registerELFGraphInfo(Session &S, LinkGraph &G) { else FileInfo.SectionInfos[Sec.getName()] = { ArrayRef<char>(FirstSym->getBlock().getContent().data(), SecSize), - SecAddr.getValue(), FirstSym->getTargetFlags()}; + SecAddr.getValue()}; } return Error::success(); diff --git a/llvm/tools/llvm-jitlink/llvm-jitlink-macho.cpp b/llvm/tools/llvm-jitlink/llvm-jitlink-macho.cpp index 7dcadd9..bcb2f25 100644 --- a/llvm/tools/llvm-jitlink/llvm-jitlink-macho.cpp +++ b/llvm/tools/llvm-jitlink/llvm-jitlink-macho.cpp @@ -117,9 +117,8 @@ Error registerMachOGraphInfo(Session &S, LinkGraph &G) { inconvertibleErrorCode()); if (auto TS = getMachOGOTTarget(G, Sym->getBlock())) - FileInfo.GOTEntryInfos[TS->getName()] = {Sym->getSymbolContent(), - Sym->getAddress().getValue(), - Sym->getTargetFlags()}; + FileInfo.GOTEntryInfos[TS->getName()] = { + Sym->getSymbolContent(), Sym->getAddress().getValue()}; else return TS.takeError(); SectionContainsContent = true; @@ -130,8 +129,7 @@ Error registerMachOGraphInfo(Session &S, LinkGraph &G) { if (auto TS = getMachOStubTarget(G, Sym->getBlock())) FileInfo.StubInfos[TS->getName()] = {Sym->getSymbolContent(), - Sym->getAddress().getValue(), - Sym->getTargetFlags()}; + Sym->getAddress().getValue()}; else return TS.takeError(); SectionContainsContent = true; @@ -142,8 +140,7 @@ Error registerMachOGraphInfo(Session &S, LinkGraph &G) { SectionContainsZeroFill = true; } else { S.SymbolInfos[Sym->getName()] = {Sym->getSymbolContent(), - Sym->getAddress().getValue(), - Sym->getTargetFlags()}; + Sym->getAddress().getValue()}; SectionContainsContent = true; } } @@ -163,7 +160,7 @@ Error registerMachOGraphInfo(Session &S, LinkGraph &G) { else FileInfo.SectionInfos[Sec.getName()] = { ArrayRef<char>(FirstSym->getBlock().getContent().data(), SecSize), - SecAddr.getValue(), FirstSym->getTargetFlags()}; + SecAddr.getValue()}; } return Error::success(); diff --git a/llvm/tools/llvm-jitlink/llvm-jitlink.cpp b/llvm/tools/llvm-jitlink/llvm-jitlink.cpp index a8f056e..00dd520 100644 --- a/llvm/tools/llvm-jitlink/llvm-jitlink.cpp +++ b/llvm/tools/llvm-jitlink/llvm-jitlink.cpp @@ -1388,8 +1388,7 @@ static Error addAbsoluteSymbols(Session &S, return Err; // Register the absolute symbol with the session symbol infos. - S.SymbolInfos[Name] = {ArrayRef<char>(), Addr, - AbsDef.getFlags().getTargetFlags()}; + S.SymbolInfos[Name] = {ArrayRef<char>(), Addr}; } return Error::success(); @@ -1857,12 +1856,15 @@ getTargetInfo(const Triple &TT, std::move(MAI), std::move(Ctx), std::move(Disassembler), std::move(MII), std::move(MIA), std::move(InstPrinter)}; } -static Error runChecks(Session &S, Triple TT, SubtargetFeatures Features) { + +static Error runChecks(Session &S) { if (CheckFiles.empty()) return Error::success(); LLVM_DEBUG(dbgs() << "Running checks...\n"); + auto TI = getTargetInfo(S.ES.getTargetTriple(), S.Features); + auto IsSymbolValid = [&S](StringRef Symbol) { return S.isSymbolRegistered(Symbol); }; @@ -1886,7 +1888,7 @@ static Error runChecks(Session &S, Triple TT, SubtargetFeatures Features) { RuntimeDyldChecker Checker( IsSymbolValid, GetSymbolInfo, GetSectionInfo, GetStubInfo, GetGOTInfo, S.ES.getTargetTriple().isLittleEndian() ? support::little : support::big, - TT, Features, dbgs()); + TI.Disassembler.get(), TI.InstPrinter.get(), dbgs()); std::string CheckLineStart = "# " + CheckName + ":"; for (auto &CheckFile : CheckFiles) { @@ -1998,7 +2000,7 @@ int main(int argc, char *argv[]) { auto [TT, Features] = getFirstFileTripleAndFeatures(); ExitOnErr(sanitizeArguments(TT, argv[0])); - auto S = ExitOnErr(Session::Create(TT, Features)); + auto S = ExitOnErr(Session::Create(std::move(TT), std::move(Features))); enableStatistics(*S, !OrcRuntime.empty()); @@ -2034,7 +2036,7 @@ int main(int argc, char *argv[]) { exit(1); } - ExitOnErr(runChecks(*S, std::move(TT), std::move(Features))); + ExitOnErr(runChecks(*S)); int Result = 0; if (!NoExec) { |