diff options
| author | Hans Wennborg <hans@chromium.org> | 2020-10-19 12:23:22 +0200 |
|---|---|---|
| committer | Hans Wennborg <hans@chromium.org> | 2020-10-19 12:31:14 +0200 |
| commit | 0628bea5137047232f37c94b74bf26aa9b55f605 (patch) | |
| tree | fea0f440c6c3e7b20d4575a0de32bc203153df41 /llvm/test/Transforms/CodeExtractor | |
| parent | d0f287464d8a2b6940cc968850b7a013c665981a (diff) | |
| download | llvm-0628bea5137047232f37c94b74bf26aa9b55f605.zip llvm-0628bea5137047232f37c94b74bf26aa9b55f605.tar.gz llvm-0628bea5137047232f37c94b74bf26aa9b55f605.tar.bz2 | |
Revert "[PM/CC1] Add -f[no-]split-cold-code CC1 option to toggle splitting"
This broke Chromium's PGO build, it seems because hot-cold-splitting got turned
on unintentionally. See comment on the code review for repro etc.
> This patch adds -f[no-]split-cold-code CC1 options to clang. This allows
> the splitting pass to be toggled on/off. The current method of passing
> `-mllvm -hot-cold-split=true` to clang isn't ideal as it may not compose
> correctly (say, with `-O0` or `-Oz`).
>
> To implement the -fsplit-cold-code option, an attribute is applied to
> functions to indicate that they may be considered for splitting. This
> removes some complexity from the old/new PM pipeline builders, and
> behaves as expected when LTO is enabled.
>
> Co-authored by: Saleem Abdulrasool <compnerd@compnerd.org>
> Differential Revision: https://reviews.llvm.org/D57265
> Reviewed By: Aditya Kumar, Vedant Kumar
> Reviewers: Teresa Johnson, Aditya Kumar, Fedor Sergeev, Philip Pfaffe, Vedant Kumar
This reverts commit 273c299d5d649a0222fbde03c9a41e41913751b4.
Diffstat (limited to 'llvm/test/Transforms/CodeExtractor')
| -rw-r--r-- | llvm/test/Transforms/CodeExtractor/extract-assume.ll | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/test/Transforms/CodeExtractor/extract-assume.ll b/llvm/test/Transforms/CodeExtractor/extract-assume.ll index 5c7918b..bf0d2ec 100644 --- a/llvm/test/Transforms/CodeExtractor/extract-assume.ll +++ b/llvm/test/Transforms/CodeExtractor/extract-assume.ll @@ -9,7 +9,7 @@ declare void @fun2(i32) #0 -define void @fun(i32 %x) "hot-cold-split" { +define void @fun(i32 %x) { entry: br i1 undef, label %if.then, label %if.else |