aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/IRReader
diff options
context:
space:
mode:
authorAbhina Sreeskantharajan <Abhina.Sreeskantharajan@ibm.com>2021-03-25 09:47:25 -0400
committerAbhina Sreeskantharajan <Abhina.Sreeskantharajan@ibm.com>2021-03-25 09:47:49 -0400
commitc83cd8feef7eb8319131d968bb8c94fdc8dbb6a6 (patch)
treed05e472da6cc9f329ec6c51095012818f6847333 /llvm/lib/IRReader
parent0becc4d721d0036e2e38d581bc487e27f78eb8a9 (diff)
downloadllvm-c83cd8feef7eb8319131d968bb8c94fdc8dbb6a6.zip
llvm-c83cd8feef7eb8319131d968bb8c94fdc8dbb6a6.tar.gz
llvm-c83cd8feef7eb8319131d968bb8c94fdc8dbb6a6.tar.bz2
[NFC] Reordering parameters in getFile and getFileOrSTDIN
In future patches I will be setting the IsText parameter frequently so I will refactor the args to be in the following order. I have removed the FileSize parameter because it is never used. ``` static ErrorOr<std::unique_ptr<MemoryBuffer>> getFile(const Twine &Filename, bool IsText = false, bool RequiresNullTerminator = true, bool IsVolatile = false); static ErrorOr<std::unique_ptr<MemoryBuffer>> getFileOrSTDIN(const Twine &Filename, bool IsText = false, bool RequiresNullTerminator = true); static ErrorOr<std::unique_ptr<MB>> getFileAux(const Twine &Filename, uint64_t MapSize, uint64_t Offset, bool IsText, bool RequiresNullTerminator, bool IsVolatile); static ErrorOr<std::unique_ptr<WritableMemoryBuffer>> getFile(const Twine &Filename, bool IsVolatile = false); ``` Reviewed By: jhenderson Differential Revision: https://reviews.llvm.org/D99182
Diffstat (limited to 'llvm/lib/IRReader')
-rw-r--r--llvm/lib/IRReader/IRReader.cpp4
1 files changed, 1 insertions, 3 deletions
diff --git a/llvm/lib/IRReader/IRReader.cpp b/llvm/lib/IRReader/IRReader.cpp
index cc3b206..b645e0b 100644
--- a/llvm/lib/IRReader/IRReader.cpp
+++ b/llvm/lib/IRReader/IRReader.cpp
@@ -92,9 +92,7 @@ std::unique_ptr<Module>
llvm::parseIRFile(StringRef Filename, SMDiagnostic &Err, LLVMContext &Context,
DataLayoutCallbackTy DataLayoutCallback) {
ErrorOr<std::unique_ptr<MemoryBuffer>> FileOrErr =
- MemoryBuffer::getFileOrSTDIN(Filename, /*FileSize=*/-1,
- /*RequiresNullTerminator=*/true,
- /*IsText=*/true);
+ MemoryBuffer::getFileOrSTDIN(Filename, /*IsText=*/true);
if (std::error_code EC = FileOrErr.getError()) {
Err = SMDiagnostic(Filename, SourceMgr::DK_Error,
"Could not open input file: " + EC.message());