aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/IR
diff options
context:
space:
mode:
authorSirraide <aeternalmail@gmail.com>2024-03-13 17:39:23 +0100
committerGitHub <noreply@github.com>2024-03-13 17:39:23 +0100
commit69afb9d7875d79fdacaaa2f22b5ee3a06faf5373 (patch)
treeb8516c8a1d651583c5dfdf6a77e818f9a6c7e251 /llvm/lib/IR
parentccd16085f70105d457f052543d731dd51089945b (diff)
downloadllvm-69afb9d7875d79fdacaaa2f22b5ee3a06faf5373.zip
llvm-69afb9d7875d79fdacaaa2f22b5ee3a06faf5373.tar.gz
llvm-69afb9d7875d79fdacaaa2f22b5ee3a06faf5373.tar.bz2
[Clang] [Sema] Fix bug in `_Complex float`+`int` arithmetic (#83063)
C23 6.3.1.8 ‘Usual arithmetic conversions’ p1 states (emphasis mine): > Otherwise, if the corresponding real type of either operand is `float`, the other operand is converted, *without change of type domain*, to a type whose corresponding real type is `float`. ‘type domain’ here refers to `_Complex` vs real (i.e. non-`_Complex`); there is another clause that states the same for `double`. Consider the following code: ```c++ _Complex float f; int x; f / x; ``` After talking this over with @AaronBallman, we came to the conclusion that `x` should be converted to `float` and *not* `_Complex float` (that is, we should perform a division of `_Complex float / float`, and *not* `_Complex float / _Complex float`; the same also applies to `-+*`). This was already being done correctly for cases where `x` was already a `float`; it’s just mixed `_Complex float`+`int` operations that currently suffer from this problem. This pr removes the extra `FloatingRealToComplex` conversion that we were erroneously inserting and adds some tests to make sure we’re actually doing `_Complex float / float` and not `_Complex float / _Complex float` (and analogously for `double` and `-+*`). The only exception here is `float / _Complex float`, which calls a library function (`__divsc3`) that takes 4 `float`s, so we end up having to convert the `float` to a `_Complex float` after all (and analogously for `double`); I don’t believe there is a way around this. Lastly, we were also missing tests for `_Complex` arithmetic at compile time, so this adds some tests for that as well.
Diffstat (limited to 'llvm/lib/IR')
0 files changed, 0 insertions, 0 deletions