diff options
author | Nikita Popov <npopov@redhat.com> | 2022-12-09 11:57:50 +0100 |
---|---|---|
committer | Nikita Popov <npopov@redhat.com> | 2022-12-12 09:34:20 +0100 |
commit | 8005332835246c54a4a6b026eede930ed559deb4 (patch) | |
tree | a32c7017b07fc370952ee11835b272890e86059a /llvm/lib/CodeGen | |
parent | a06342d250ec7bee37dc93477f233e43e597aca5 (diff) | |
download | llvm-8005332835246c54a4a6b026eede930ed559deb4.zip llvm-8005332835246c54a4a6b026eede930ed559deb4.tar.gz llvm-8005332835246c54a4a6b026eede930ed559deb4.tar.bz2 |
[AA] Remove CFL AA passes
The CFL Steens/Anders alias analysis passes are not enabled by
default, and to the best of my knowledge have no pathway towards
ever being enabled by default. The last significant interest in
these passes seems to date back to 2016. Given the little
maintenance these have seen in recent times, I also have very
little confidence in the correctness of these passes. I don't
think we should keep these in-tree.
Differential Revision: https://reviews.llvm.org/D139703
Diffstat (limited to 'llvm/lib/CodeGen')
-rw-r--r-- | llvm/lib/CodeGen/TargetPassConfig.cpp | 30 |
1 files changed, 0 insertions, 30 deletions
diff --git a/llvm/lib/CodeGen/TargetPassConfig.cpp b/llvm/lib/CodeGen/TargetPassConfig.cpp index 87f29b3..115f266 100644 --- a/llvm/lib/CodeGen/TargetPassConfig.cpp +++ b/llvm/lib/CodeGen/TargetPassConfig.cpp @@ -16,8 +16,6 @@ #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/StringRef.h" #include "llvm/Analysis/BasicAliasAnalysis.h" -#include "llvm/Analysis/CFLAndersAliasAnalysis.h" -#include "llvm/Analysis/CFLSteensAliasAnalysis.h" #include "llvm/Analysis/CallGraphSCCPass.h" #include "llvm/Analysis/ScopedNoAliasAA.h" #include "llvm/Analysis/TargetTransformInfo.h" @@ -209,18 +207,6 @@ static cl::opt<bool> MISchedPostRA( static cl::opt<bool> EarlyLiveIntervals("early-live-intervals", cl::Hidden, cl::desc("Run live interval analysis earlier in the pipeline")); -// Experimental option to use CFL-AA in codegen -static cl::opt<CFLAAType> UseCFLAA( - "use-cfl-aa-in-codegen", cl::init(CFLAAType::None), cl::Hidden, - cl::desc("Enable the new, experimental CFL alias analysis in CodeGen"), - cl::values(clEnumValN(CFLAAType::None, "none", "Disable CFL-AA"), - clEnumValN(CFLAAType::Steensgaard, "steens", - "Enable unification-based CFL-AA"), - clEnumValN(CFLAAType::Andersen, "anders", - "Enable inclusion-based CFL-AA"), - clEnumValN(CFLAAType::Both, "both", - "Enable both variants of CFL-AA"))); - /// Option names for limiting the codegen pipeline. /// Those are used in error reporting and we didn't want /// to duplicate their names all over the place. @@ -493,7 +479,6 @@ CGPassBuilderOption llvm::getCGPassBuilderOption() { SET_BOOLEAN_OPTION(EnableImplicitNullChecks) SET_BOOLEAN_OPTION(EnableMachineOutliner) SET_BOOLEAN_OPTION(MISchedPostRA) - SET_BOOLEAN_OPTION(UseCFLAA) SET_BOOLEAN_OPTION(DisableMergeICmps) SET_BOOLEAN_OPTION(DisableLSR) SET_BOOLEAN_OPTION(DisableConstantHoisting) @@ -858,21 +843,6 @@ void TargetPassConfig::addIRPasses() { addPass(createVerifierPass()); if (getOptLevel() != CodeGenOpt::None) { - switch (UseCFLAA) { - case CFLAAType::Steensgaard: - addPass(createCFLSteensAAWrapperPass()); - break; - case CFLAAType::Andersen: - addPass(createCFLAndersAAWrapperPass()); - break; - case CFLAAType::Both: - addPass(createCFLAndersAAWrapperPass()); - addPass(createCFLSteensAAWrapperPass()); - break; - default: - break; - } - // Basic AliasAnalysis support. // Add TypeBasedAliasAnalysis before BasicAliasAnalysis so that // BasicAliasAnalysis wins if they disagree. This is intended to help |