diff options
author | Jonas Devlieghere <jonas@devlieghere.com> | 2024-02-28 15:23:55 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-02-28 15:23:55 -0800 |
commit | d3173f4ab61c17337908eb7df3f1c515ddcd428c (patch) | |
tree | 6b0c2a7faa66b119b2339ebf5bf409b98ba6de18 /lldb/tools | |
parent | 0f76d9fb5fbfea92da7647af70d78165c71c0700 (diff) | |
download | llvm-d3173f4ab61c17337908eb7df3f1c515ddcd428c.zip llvm-d3173f4ab61c17337908eb7df3f1c515ddcd428c.tar.gz llvm-d3173f4ab61c17337908eb7df3f1c515ddcd428c.tar.bz2 |
[lldb] Remove -d(ebug) mode from the lldb driver (#83330)
The -d(ebug) option broke 5 years ago when I migrated the driver to
libOption. Since then, we were never check if the option is set. We were
incorrectly toggling the internal variable (m_debug_mode) based on
OPT_no_use_colors instead.
Given that the functionality doesn't seem particularly useful and nobody
noticed it has been broken for 5 years, I'm just removing the flag.
Diffstat (limited to 'lldb/tools')
-rw-r--r-- | lldb/tools/driver/Driver.cpp | 15 | ||||
-rw-r--r-- | lldb/tools/driver/Driver.h | 1 |
2 files changed, 0 insertions, 16 deletions
diff --git a/lldb/tools/driver/Driver.cpp b/lldb/tools/driver/Driver.cpp index c63ff0f..9286abb 100644 --- a/lldb/tools/driver/Driver.cpp +++ b/lldb/tools/driver/Driver.cpp @@ -188,7 +188,6 @@ SBError Driver::ProcessArgs(const opt::InputArgList &args, bool &exiting) { if (args.hasArg(OPT_no_use_colors)) { m_debugger.SetUseColor(false); WithColor::setAutoDetectFunction(disable_color); - m_option_data.m_debug_mode = true; } if (args.hasArg(OPT_version)) { @@ -455,16 +454,7 @@ int Driver::MainLoop() { // Process lldbinit files before handling any options from the command line. SBCommandReturnObject result; sb_interpreter.SourceInitFileInGlobalDirectory(result); - if (m_option_data.m_debug_mode) { - result.PutError(m_debugger.GetErrorFile()); - result.PutOutput(m_debugger.GetOutputFile()); - } - sb_interpreter.SourceInitFileInHomeDirectory(result, m_option_data.m_repl); - if (m_option_data.m_debug_mode) { - result.PutError(m_debugger.GetErrorFile()); - result.PutOutput(m_debugger.GetOutputFile()); - } // Source the local .lldbinit file if it exists and we're allowed to source. // Here we want to always print the return object because it contains the @@ -536,11 +526,6 @@ int Driver::MainLoop() { "or -s) are ignored in REPL mode.\n"; } - if (m_option_data.m_debug_mode) { - result.PutError(m_debugger.GetErrorFile()); - result.PutOutput(m_debugger.GetOutputFile()); - } - const bool handle_events = true; const bool spawn_thread = false; diff --git a/lldb/tools/driver/Driver.h b/lldb/tools/driver/Driver.h index d5779b3..83e0d8a 100644 --- a/lldb/tools/driver/Driver.h +++ b/lldb/tools/driver/Driver.h @@ -75,7 +75,6 @@ public: std::vector<InitialCmdEntry> m_after_file_commands; std::vector<InitialCmdEntry> m_after_crash_commands; - bool m_debug_mode = false; bool m_source_quietly = false; bool m_print_version = false; bool m_print_python_path = false; |