aboutsummaryrefslogtreecommitdiff
path: root/libc
diff options
context:
space:
mode:
authorNick Desaulniers <nickdesaulniers@users.noreply.github.com>2024-03-12 08:39:17 -0700
committerGitHub <noreply@github.com>2024-03-12 08:39:17 -0700
commitf0c0ddae45ec929d023232d2ff0b75b7f09853c2 (patch)
tree9d728d71e14fe283968368b34d0a102a724dc815 /libc
parentbae47d48b632a4fa1dce5591bc0783360cf69e28 (diff)
downloadllvm-f0c0ddae45ec929d023232d2ff0b75b7f09853c2.zip
llvm-f0c0ddae45ec929d023232d2ff0b75b7f09853c2.tar.gz
llvm-f0c0ddae45ec929d023232d2ff0b75b7f09853c2.tar.bz2
[libc] implement the final macros for stdbit.h support (#84798)
Relevant sections of n3096: - 7.18.1p1 - 7.18.2
Diffstat (limited to 'libc')
-rw-r--r--libc/docs/c23.rst2
-rw-r--r--libc/docs/stdbit.rst8
-rw-r--r--libc/include/llvm-libc-macros/stdbit-macros.h5
-rw-r--r--libc/spec/stdc.td4
-rw-r--r--libc/test/include/stdbit_test.cpp17
5 files changed, 31 insertions, 5 deletions
diff --git a/libc/docs/c23.rst b/libc/docs/c23.rst
index 24cef85..3f64722 100644
--- a/libc/docs/c23.rst
+++ b/libc/docs/c23.rst
@@ -75,7 +75,7 @@ Additions:
* dfmal
* fsqrt*
* dsqrtl
-* stdbit.h (New header)
+* stdbit.h (New header) |check|
* stdckdint.h (New header) |check|
* stddef.h
diff --git a/libc/docs/stdbit.rst b/libc/docs/stdbit.rst
index 9b4974c..d42f7938 100644
--- a/libc/docs/stdbit.rst
+++ b/libc/docs/stdbit.rst
@@ -110,10 +110,10 @@ Macros
========================= =========
Macro Name Available
========================= =========
-__STDC_VERSION_STDBIT_H__
-__STDC_ENDIAN_LITTLE__
-__STDC_ENDIAN_BIG__
-__STDC_ENDIAN_NATIVE__
+__STDC_VERSION_STDBIT_H__ |check|
+__STDC_ENDIAN_LITTLE__ |check|
+__STDC_ENDIAN_BIG__ |check|
+__STDC_ENDIAN_NATIVE__ |check|
stdc_leading_zeros |check|
stdc_leading_ones |check|
stdc_trailing_zeros |check|
diff --git a/libc/include/llvm-libc-macros/stdbit-macros.h b/libc/include/llvm-libc-macros/stdbit-macros.h
index 10c0fac..c5b2f09 100644
--- a/libc/include/llvm-libc-macros/stdbit-macros.h
+++ b/libc/include/llvm-libc-macros/stdbit-macros.h
@@ -9,6 +9,11 @@
#ifndef __LLVM_LIBC_MACROS_STDBIT_MACROS_H
#define __LLVM_LIBC_MACROS_STDBIT_MACROS_H
+#define __STDC_VERSION_STDBIT_H__ 202311L
+#define __STDC_ENDIAN_LITTLE__ __ORDER_LITTLE_ENDIAN__
+#define __STDC_ENDIAN_BIG__ __ORDER_BIG_ENDIAN__
+#define __STDC_ENDIAN_NATIVE__ __BYTE_ORDER__
+
// TODO(https://github.com/llvm/llvm-project/issues/80509): support _BitInt().
#ifdef __cplusplus
inline unsigned stdc_leading_zeros(unsigned char x) {
diff --git a/libc/spec/stdc.td b/libc/spec/stdc.td
index 1f14fe7..1f9917b1 100644
--- a/libc/spec/stdc.td
+++ b/libc/spec/stdc.td
@@ -805,6 +805,10 @@ def StdC : StandardSpec<"stdc"> {
HeaderSpec StdBit = HeaderSpec<
"stdbit.h",
[
+ Macro<"__STDC_VERSION_STDBIT_H__">,
+ Macro<"__STDC_ENDIAN_LITTLE__">,
+ Macro<"__STDC_ENDIAN_BIG__">,
+ Macro<"__STDC_ENDIAN_NATIVE__">,
Macro<"stdc_leading_zeros">,
Macro<"stdc_leading_ones">,
Macro<"stdc_trailing_zeros">,
diff --git a/libc/test/include/stdbit_test.cpp b/libc/test/include/stdbit_test.cpp
index f3227eb..bee1a19 100644
--- a/libc/test/include/stdbit_test.cpp
+++ b/libc/test/include/stdbit_test.cpp
@@ -141,3 +141,20 @@ TEST(LlvmLibcStdbitTest, TypeGenericMacroBitCeil) {
EXPECT_EQ(stdc_bit_ceil(0UL), 0x6DUL);
EXPECT_EQ(stdc_bit_ceil(0ULL), 0x6EULL);
}
+
+TEST(LlvmLibcStdbitTest, VersionMacro) {
+ // 7.18.1p2 an integer constant expression with a value equivalent to 202311L.
+ EXPECT_EQ(__STDC_VERSION_STDBIT_H__, 202311L);
+}
+
+TEST(LlvmLibcStdbitTest, EndianMacros) {
+ // 7.18.2p3 The values of the integer constant expressions for
+ // __STDC_ENDIAN_LITTLE__ and __STDC_ENDIAN_BIG__ are not equal.
+ EXPECT_NE(__STDC_ENDIAN_LITTLE__, __STDC_ENDIAN_BIG__);
+ // The standard does allow for __STDC_ENDIAN_NATIVE__ to be an integer
+ // constant expression with an implementation defined value for non-big or
+ // little endianness environments. I assert such machines are no longer
+ // relevant.
+ EXPECT_TRUE(__STDC_ENDIAN_NATIVE__ == __STDC_ENDIAN_LITTLE__ ||
+ __STDC_ENDIAN_NATIVE__ == __STDC_ENDIAN_BIG__);
+}