diff options
author | Ingo Müller <ingomueller@google.com> | 2023-06-19 07:15:01 +0000 |
---|---|---|
committer | Ingo Müller <ingomueller@google.com> | 2023-06-19 07:38:51 +0000 |
commit | 0eb0fecbc544a0416b70f4450a38dfb27c9b5b9a (patch) | |
tree | 9fb6e199ae1a49f5dc8e6efd32c425531ed88ccd /libc/startup | |
parent | 53f6229328851a6779a1cac0cd72f746fee3ae65 (diff) | |
download | llvm-0eb0fecbc544a0416b70f4450a38dfb27c9b5b9a.zip llvm-0eb0fecbc544a0416b70f4450a38dfb27c9b5b9a.tar.gz llvm-0eb0fecbc544a0416b70f4450a38dfb27c9b5b9a.tar.bz2 |
[mlir][ExecutionEngine] Only load JITDyLibs without init/destroy funcs.
In https://reviews.llvm.org/D153029, I moved the loading/unloading
mechanisms of shared libraries from the JIT runner to the execution
engine in order to make that mechanism available in the latter
(including its Python bindings). However, I realized that I introduced a
small change in semantic: previously, the JIT runner checked for the
presence of init/destroy functions and only loaded the library as
JITDyLib if they were not present. After I moved the code, all libraries
were loaded as JITDyLib, even if they registered their symbols
explicitly in their init function. I am not sure if this is really a
problem but (1) the previous behavior was different and (2) I guess it
could cause a problem if some symbols are exported through the init
function *and* have public visibility. This patch reestablishes the
original behaviour in the new place of the code.
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D153249
Diffstat (limited to 'libc/startup')
0 files changed, 0 insertions, 0 deletions