aboutsummaryrefslogtreecommitdiff
path: root/clang/unittests
diff options
context:
space:
mode:
authorVitaly Buka <vitalybuka@google.com>2022-07-16 14:03:22 -0700
committerVitaly Buka <vitalybuka@google.com>2022-07-16 14:03:38 -0700
commit45067f8fbf61284839c739807c2da2e2505661eb (patch)
tree2ca8d7068e431f6f253290126f7a0802dd5f3a0b /clang/unittests
parent7ca3e23f250dc679bdd6660fd6877e1e5c275871 (diff)
downloadllvm-45067f8fbf61284839c739807c2da2e2505661eb.zip
llvm-45067f8fbf61284839c739807c2da2e2505661eb.tar.gz
llvm-45067f8fbf61284839c739807c2da2e2505661eb.tar.bz2
[test] Don't leak DerivedArgList in test
Diffstat (limited to 'clang/unittests')
-rw-r--r--clang/unittests/Driver/ToolChainTest.cpp16
1 files changed, 10 insertions, 6 deletions
diff --git a/clang/unittests/Driver/ToolChainTest.cpp b/clang/unittests/Driver/ToolChainTest.cpp
index 3637b10..02ab9e7 100644
--- a/clang/unittests/Driver/ToolChainTest.cpp
+++ b/clang/unittests/Driver/ToolChainTest.cpp
@@ -486,8 +486,8 @@ TEST(DxcModeTest, ValidatorVersionValidation) {
for (auto *A : Args)
DAL->append(A);
- auto *TranslatedArgs =
- TC.TranslateArgs(*DAL, "0", Action::OffloadKind::OFK_None);
+ std::unique_ptr<llvm::opt::DerivedArgList> TranslatedArgs{
+ TC.TranslateArgs(*DAL, "0", Action::OffloadKind::OFK_None)};
EXPECT_NE(TranslatedArgs, nullptr);
if (TranslatedArgs) {
auto *A = TranslatedArgs->getLastArg(
@@ -506,7 +506,8 @@ TEST(DxcModeTest, ValidatorVersionValidation) {
for (auto *A : Args)
DAL->append(A);
- TranslatedArgs = TC.TranslateArgs(*DAL, "0", Action::OffloadKind::OFK_None);
+ TranslatedArgs.reset(
+ TC.TranslateArgs(*DAL, "0", Action::OffloadKind::OFK_None));
EXPECT_EQ(Diags.getNumErrors(), 1u);
EXPECT_STREQ(DiagConsumer->Errors.back().c_str(),
"invalid validator version : 0.1\nIf validator major version is "
@@ -521,7 +522,8 @@ TEST(DxcModeTest, ValidatorVersionValidation) {
for (auto *A : Args)
DAL->append(A);
- TranslatedArgs = TC.TranslateArgs(*DAL, "0", Action::OffloadKind::OFK_None);
+ TranslatedArgs.reset(
+ TC.TranslateArgs(*DAL, "0", Action::OffloadKind::OFK_None));
EXPECT_EQ(Diags.getNumErrors(), 2u);
EXPECT_STREQ(DiagConsumer->Errors.back().c_str(),
"invalid validator version : 1\nFormat of validator version is "
@@ -536,7 +538,8 @@ TEST(DxcModeTest, ValidatorVersionValidation) {
for (auto *A : Args)
DAL->append(A);
- TranslatedArgs = TC.TranslateArgs(*DAL, "0", Action::OffloadKind::OFK_None);
+ TranslatedArgs.reset(
+ TC.TranslateArgs(*DAL, "0", Action::OffloadKind::OFK_None));
EXPECT_EQ(Diags.getNumErrors(), 3u);
EXPECT_STREQ(
DiagConsumer->Errors.back().c_str(),
@@ -552,7 +555,8 @@ TEST(DxcModeTest, ValidatorVersionValidation) {
for (auto *A : Args)
DAL->append(A);
- TranslatedArgs = TC.TranslateArgs(*DAL, "0", Action::OffloadKind::OFK_None);
+ TranslatedArgs.reset(
+ TC.TranslateArgs(*DAL, "0", Action::OffloadKind::OFK_None));
EXPECT_EQ(Diags.getNumErrors(), 4u);
EXPECT_STREQ(
DiagConsumer->Errors.back().c_str(),