diff options
author | Balazs Benics <benicsbalazs@gmail.com> | 2022-10-13 08:41:31 +0200 |
---|---|---|
committer | Tom Stellard <tstellar@redhat.com> | 2022-11-15 15:37:36 -0800 |
commit | 11c3a21f8d1ba21c7744ba9d272c26c2ce3c58a0 (patch) | |
tree | fd56fb9a0f01eb11803984c3e0e4be929e1226c8 /clang/lib | |
parent | 0988addf2680b3717be47fd6f2493f33fe886f90 (diff) | |
download | llvm-11c3a21f8d1ba21c7744ba9d272c26c2ce3c58a0.zip llvm-11c3a21f8d1ba21c7744ba9d272c26c2ce3c58a0.tar.gz llvm-11c3a21f8d1ba21c7744ba9d272c26c2ce3c58a0.tar.bz2 |
[analyzer] Workaround crash on encountering Class non-type template parameters
The Clang Static Analyzer will crash on this code:
```lang=C++
struct Box {
int value;
};
template <Box V> int get() {
return V.value;
}
template int get<Box{-1}>();
```
https://godbolt.org/z/5Yb1sMMMb
The problem is that we don't account for encountering `TemplateParamObjectDecl`s
within the `DeclRefExpr` handler in the `ExprEngine`.
IMO we should create a new memregion for representing such template
param objects, to model their language semantics.
Such as:
- it should have global static storage
- for two identical values, their addresses should be identical as well
http://eel.is/c%2B%2Bdraft/temp.param#8
I was thinking of introducing a `TemplateParamObjectRegion` under `DeclRegion`
for this purpose. It could have `TemplateParamObjectDecl` as a field.
The `TemplateParamObjectDecl::getValue()` returns `APValue`, which might
represent multiple levels of structures, unions and other goodies -
making the transformation from `APValue` to `SVal` a bit complicated.
That being said, for now, I think having `Unknowns` for such cases is
definitely an improvement to crashing, hence I'm proposing this patch.
Reviewed By: xazax.hun
Differential Revision: https://reviews.llvm.org/D135763
(cherry picked from commit b062ee7dc4515b0a42157717105839627d5542bb)
Diffstat (limited to 'clang/lib')
-rw-r--r-- | clang/lib/StaticAnalyzer/Core/ExprEngine.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp b/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp index 19149d0..ab65612 100644 --- a/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp +++ b/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp @@ -2839,6 +2839,12 @@ void ExprEngine::VisitCommonDeclRefExpr(const Expr *Ex, const NamedDecl *D, return; } + if (const auto *TPO = dyn_cast<TemplateParamObjectDecl>(D)) { + // FIXME: We should meaningfully implement this. + (void)TPO; + return; + } + llvm_unreachable("Support for this Decl not implemented."); } |