diff options
author | Piotr Zegar <me@piotrzegar.pl> | 2024-02-29 20:52:32 +0000 |
---|---|---|
committer | Piotr Zegar <me@piotrzegar.pl> | 2024-02-29 20:53:30 +0000 |
commit | 21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85 (patch) | |
tree | 3e6875553089750dffd647c721263236a1a59d7d /clang-tools-extra | |
parent | cff36bb198759c4fe557adc594eabc097cf7d565 (diff) | |
download | llvm-21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85.zip llvm-21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85.tar.gz llvm-21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85.tar.bz2 |
[clang-tidy][NFC] Fix buffer overflow in modernize-use-designated-initializers
Instance of DenseMap were copied into local variable,
and as a result reference to string stored in that local
variable were returned from function. At the end fix-it
were applied with already destroyed string causing some
non utf-8 characters to be printed.
Related to #80541
Diffstat (limited to 'clang-tools-extra')
-rw-r--r-- | clang-tools-extra/clang-tidy/modernize/UseDesignatedInitializersCheck.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-tidy/modernize/UseDesignatedInitializersCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseDesignatedInitializersCheck.cpp index 9ff6bb1..ebc5338 100644 --- a/clang-tools-extra/clang-tidy/modernize/UseDesignatedInitializersCheck.cpp +++ b/clang-tools-extra/clang-tidy/modernize/UseDesignatedInitializersCheck.cpp @@ -43,7 +43,7 @@ struct Designators { unsigned size() { return getCached().size(); } std::optional<llvm::StringRef> operator[](const SourceLocation &Location) { - const auto Designators = getCached(); + const auto &Designators = getCached(); const auto Result = Designators.find(Location); if (Result == Designators.end()) return {}; |