diff options
| author | Adrian Prantl <aprantl@apple.com> | 2024-04-19 16:36:15 -0700 |
|---|---|---|
| committer | Adrian Prantl <aprantl@apple.com> | 2024-04-19 16:37:09 -0700 |
| commit | c8627e4e0c8ac453844638522b887ac7b7687672 (patch) | |
| tree | 24e508b6d1f60cfbe808f55743218928b2005d22 | |
| parent | 11019be4cf75ff40d2da84094477ab5dac818c99 (diff) | |
| download | llvm-c8627e4e0c8ac453844638522b887ac7b7687672.zip llvm-c8627e4e0c8ac453844638522b887ac7b7687672.tar.gz llvm-c8627e4e0c8ac453844638522b887ac7b7687672.tar.bz2 | |
Revert "[lldb] Provide a better error message for missing symbols (#89433)"
This reverts commit 08163cd9d82690e808c28515523b5fd0923d7b38.
I accidentally broke the test while addressing review feedback.
| -rw-r--r-- | lldb/source/Expression/IRExecutionUnit.cpp | 4 | ||||
| -rw-r--r-- | lldb/test/API/lang/cpp/constructors/TestCppConstructors.py | 2 |
2 files changed, 2 insertions, 4 deletions
diff --git a/lldb/source/Expression/IRExecutionUnit.cpp b/lldb/source/Expression/IRExecutionUnit.cpp index 07df8c5..cb9bee8 100644 --- a/lldb/source/Expression/IRExecutionUnit.cpp +++ b/lldb/source/Expression/IRExecutionUnit.cpp @@ -431,9 +431,7 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr, } m_failed_lookups.clear(); - ss.PutCString( - "\nHint: The expression tried to call a function that is not present " - "in the target, perhaps because it was optimized out by the compiler."); + error.SetErrorString(ss.GetString()); return; diff --git a/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py b/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py index 140877a..6724bfc 100644 --- a/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py +++ b/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py @@ -47,7 +47,7 @@ class TestCase(TestBase): self.expect( "expr ClassWithDeletedDefaultCtor().value", error=True, - substrs=["Couldn't look up symbols:", "function missing"], + substrs=["Couldn't look up symbols:"], ) @skipIfWindows # Can't find operator new. |