diff options
| author | Florian Mayer <fmayer@google.com> | 2024-04-04 12:55:05 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-04 12:55:05 -0700 |
| commit | dfaa144d0ca15839d1d11af472a4b7e2d2c6b7ec (patch) | |
| tree | 0f500fad0250deca377cd380c9339771d4271ae0 | |
| parent | c91a0a28908ec48f3775cdacede66163eb6339ff (diff) | |
| download | llvm-dfaa144d0ca15839d1d11af472a4b7e2d2c6b7ec.zip llvm-dfaa144d0ca15839d1d11af472a4b7e2d2c6b7ec.tar.gz llvm-dfaa144d0ca15839d1d11af472a4b7e2d2c6b7ec.tar.bz2 | |
[NFC] [HWASan] clarify FIXME comment (#87689)
| -rw-r--r-- | compiler-rt/lib/hwasan/hwasan_thread_list.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/compiler-rt/lib/hwasan/hwasan_thread_list.h b/compiler-rt/lib/hwasan/hwasan_thread_list.h index f36d278..369a1c3 100644 --- a/compiler-rt/lib/hwasan/hwasan_thread_list.h +++ b/compiler-rt/lib/hwasan/hwasan_thread_list.h @@ -55,6 +55,9 @@ static uptr RingBufferSize() { uptr desired_bytes = flags()->stack_history_size * sizeof(uptr); // FIXME: increase the limit to 8 once this bug is fixed: // https://bugs.llvm.org/show_bug.cgi?id=39030 + // Note that we *cannot* do that on Android, as the runtime will indefinitely + // have to support code that is compiled with ashr, which only works with + // shifts up to 6. for (int shift = 0; shift < 7; ++shift) { uptr size = 4096 * (1ULL << shift); if (size >= desired_bytes) |