diff options
author | Aiden Grossman <aidengrossman@google.com> | 2024-04-26 23:10:20 +0000 |
---|---|---|
committer | Aiden Grossman <aidengrossman@google.com> | 2024-04-26 23:10:20 +0000 |
commit | ad2816e7340be71c93e60b9bb58e107fe1b76e4d (patch) | |
tree | 0245c7180891e6d4729cf09eb7a444cdc5d16346 | |
parent | 5569c219d35c78ad60aea127a06a51e202ae5b6f (diff) | |
download | llvm-ad2816e7340be71c93e60b9bb58e107fe1b76e4d.zip llvm-ad2816e7340be71c93e60b9bb58e107fe1b76e4d.tar.gz llvm-ad2816e7340be71c93e60b9bb58e107fe1b76e4d.tar.bz2 |
[llvm-exegesis] Use const reference for range variable
In the SubprocessMemory destructor, I was using a normal std::string to
hold the name of the current shared memory name, but a const reference
works just as well in this situation while having better performance
characteristics.
Fixes #90289
-rw-r--r-- | llvm/tools/llvm-exegesis/lib/SubprocessMemory.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/tools/llvm-exegesis/lib/SubprocessMemory.cpp b/llvm/tools/llvm-exegesis/lib/SubprocessMemory.cpp index cda0440..89d7b19 100644 --- a/llvm/tools/llvm-exegesis/lib/SubprocessMemory.cpp +++ b/llvm/tools/llvm-exegesis/lib/SubprocessMemory.cpp @@ -143,7 +143,7 @@ Expected<int> SubprocessMemory::setupAuxiliaryMemoryInSubprocess( } SubprocessMemory::~SubprocessMemory() { - for (std::string SharedMemoryName : SharedMemoryNames) { + for (const std::string &SharedMemoryName : SharedMemoryNames) { if (shm_unlink(SharedMemoryName.c_str()) != 0) { errs() << "Failed to unlink shared memory section: " << strerror(errno) << "\n"; |