diff options
| author | Adrian Kuegel <akuegel@google.com> | 2024-04-08 13:12:26 +0000 |
|---|---|---|
| committer | Adrian Kuegel <akuegel@google.com> | 2024-04-08 13:13:57 +0000 |
| commit | a4c84d6ac1014b00257618663a243419630ff626 (patch) | |
| tree | f0ef2937bd58daba574a0237fa0d36488d9402bd | |
| parent | 2921a0928c71f4ee652a2478283e47ab5ffebf58 (diff) | |
| download | llvm-a4c84d6ac1014b00257618663a243419630ff626.zip llvm-a4c84d6ac1014b00257618663a243419630ff626.tar.gz llvm-a4c84d6ac1014b00257618663a243419630ff626.tar.bz2 | |
[mlir] Only inline if properties are used.
This is a followup to 0f52f4ddd909eb38f2a691ffed8469263fe5f635
It breaks dialects that don't use properties yet.
| -rw-r--r-- | mlir/test/mlir-tblgen/op-decl-and-defs.td | 4 | ||||
| -rw-r--r-- | mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/mlir/test/mlir-tblgen/op-decl-and-defs.td b/mlir/test/mlir-tblgen/op-decl-and-defs.td index 4fa2f30..499e3ce 100644 --- a/mlir/test/mlir-tblgen/op-decl-and-defs.td +++ b/mlir/test/mlir-tblgen/op-decl-and-defs.td @@ -59,9 +59,9 @@ def NS_AOp : NS_Op<"a_op", [IsolatedFromAbove, IsolatedFromAbove]> { // CHECK: class AOpGenericAdaptorBase { // CHECK: public: // CHECK: AOpGenericAdaptorBase(AOp{{[[:space:]]}} -// CHECK: ::mlir::IntegerAttr getAttr1Attr() { +// CHECK: ::mlir::IntegerAttr getAttr1Attr(); // CHECK: uint32_t getAttr1(); -// CHECK: ::mlir::FloatAttr getSomeAttr2Attr() { +// CHECK: ::mlir::FloatAttr getSomeAttr2Attr(); // CHECK: ::std::optional< ::llvm::APFloat > getSomeAttr2(); // CHECK: ::mlir::Region &getSomeRegion() { // CHECK: ::mlir::RegionRange getSomeRegions() { diff --git a/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp b/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp index 5739c7e..53ed5cb 100644 --- a/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp +++ b/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp @@ -4167,8 +4167,8 @@ OpOperandAdaptorEmitter::OpOperandAdaptorEmitter( // value, in which case the default value may be arbitrary code. auto *method = genericAdaptorBase.addMethod( attr.getStorageType(), emitName + "Attr", - attr.hasDefaultValue() ? Method::Properties::None - : Method::Properties::Inline); + attr.hasDefaultValue() || !useProperties ? Method::Properties::None + : Method::Properties::Inline); ERROR_IF_PRUNED(method, "Adaptor::" + emitName + "Attr", op); auto &body = method->body().indent(); if (!useProperties) |